Fix missing remote lockfile invalidation when URL has no path#14348
Closed
Fix missing remote lockfile invalidation when URL has no path#14348
Conversation
charliermarsh
approved these changes
Jun 29, 2025
Member
charliermarsh
left a comment
charliermarsh
left a comment
There was a problem hiding this comment.
I think we should fix without_trailing_slash to match pop_if_empty, but this is also fine for now.
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
added a commit
that referenced
this pull request
Jun 29, 2025
Member
Author
|
Preferring #14349 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14344 (comment)
Url::pop_if_empty, used atuv/crates/uv-distribution-types/src/index_url.rs
Lines 265 to 269 in 734b228
does not remove a
/if there's no path, e.g.,https://example.com/(vshttps://example.com/foo/)However,
UrlString::without_trailing_slashalways trims the trailing slashuv/crates/uv-distribution-types/src/file.rs
Lines 175 to 177 in f892b85
since these are inconsistent, we consider URLs inequal and
uv lock --checkregresses with