Return Cow from UrlString::with_ methods#14319
Merged
charliermarsh merged 2 commits intomainfrom Jun 27, 2025
Merged
Conversation
jtfmumm
commented
Jun 27, 2025
| ); | ||
| } | ||
|
|
||
| let url = UrlString("https://example.com/path#fragment".into()); |
Contributor
Author
There was a problem hiding this comment.
These base_str() checks were repeated from another test and shouldn't have been here
jtfmumm
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
jtfmumm
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
oconnor663
reviewed
Jun 27, 2025
jtfmumm
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
charliermarsh
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor performance improvement as a follow-up to #14245 (and an accompanying test).