Fix handling of inverted ~= with python_version and python_full_version#14259
Closed
Fix handling of inverted ~= with python_version and python_full_version#14259
~= with python_version and python_full_version#14259Conversation
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
ibraheemdev
reviewed
Jun 25, 2025
konstin
force-pushed
the
konsti/fix-tilde-equal-python
branch
from
2852af1 to
d94a6fa
Compare
konstin
changed the base branch from
main
to
konsti/fix-star-inequality-trailing-zeroes
konstin
had a problem deploying
to
uv-test-registries
GitHub Actions
Failure
Member
Author
|
While the isolated |
konstin
force-pushed
the
konsti/fix-star-inequality-trailing-zeroes
branch
2 times, most recently
from
5b832f5 to
c87d3a2
Compare
konstin
force-pushed
the
konsti/fix-star-inequality-trailing-zeroes
branch
from
c87d3a2 to
d4664db
Compare
konstin
force-pushed
the
konsti/fix-tilde-equal-python
branch
from
d94a6fa to
afeef20
Compare
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
konstin
force-pushed
the
konsti/fix-tilde-equal-python
branch
from
afeef20 to
207ed82
Compare
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Base automatically changed from
konsti/fix-star-inequality-trailing-zeroes
to
main
July 1, 2025 15:48
konstin
force-pushed
the
konsti/fix-tilde-equal-python
branch
from
207ed82 to
fc0871a
Compare
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
konstin
changed the title
~= with python_version and python_full_version~= with python_version and python_full_version
konstin
force-pushed
the
konsti/fix-tilde-equal-python
branch
from
fc0871a to
e62365a
Compare
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Member
Author
|
With #14271 applied, this simpler fix now seems to work. |
konstin
force-pushed
the
konsti/fix-tilde-equal-python
branch
from
e62365a to
3909dff
Compare
konstin
force-pushed
the
konsti/fix-tilde-equal-python
branch
from
3909dff to
221a079
Compare
Member
Author
|
@ibraheemdev Given that this works and it only changes (fixes) the behavior of an edge case, should we go ahead and merge this? |
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the handling of
"<version>" ~= python_versionand"<version>" ~= python_full_version, which need custom handling as we know the number of digits on the RHS, but not their meaning.