Use emscripten platform tags for Pyodide#14226
Closed
charliermarsh wants to merge 1 commit intomainfrom
Closed
Conversation
Merged
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Member
Author
|
Nevermind, it looks like some pyodide wheels do use |
CodSpeed WallTime Performance ReportMerging #14226 will degrade performances by 17.14%Comparing Summary
Benchmarks breakdown
|
charliermarsh
force-pushed
the
charlie/em
branch
from
7261c99 to
0cdfb39
Compare
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I think the platform tag for Pyodide 2024 wheels is
emscripten_3_1_58_wasm32. As far as I can tell, thepyodide_2024_0_wasm32piece doesn't actually show up in the wheels themselves, though I could be misunderstanding.Builds on #12731.
Test Plan