use $TMPDIR/uv-locks instead of putting lockfiles directly in $TMPDIR#14225
Closed
oconnor663 wants to merge 1 commit intojack/lock_wheel_buildsfrom
Closed
use $TMPDIR/uv-locks instead of putting lockfiles directly in $TMPDIR#14225oconnor663 wants to merge 1 commit intojack/lock_wheel_buildsfrom
oconnor663 wants to merge 1 commit intojack/lock_wheel_buildsfrom
Conversation
oconnor663
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Contributor
Author
|
I'm closing this for now. Ad-hoc proxy file locking is done in a lot of different ways, e.g.: uv/crates/uv/src/commands/project/mod.rs Lines 721 to 746 in 4b34851 It might be nice to refactor that (and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @zanieb has pointed out in chat, moving file locks around makes us vulnerable to races between different versions of
uvthat don't agree on the file lock path. I'm comfortable ignoring that as rare enough not to matter, but I'm curious what other folks think.Atomically creating a directory with universal write permissions also turned out to be surprisingly complicated, requiring us to spawn a shell command that first sets
umask. My instinct is that this command will be portable to all flavors of Unix, but if we'd rather skip shelling out and tolerate the extremely brief mkdir-then-chmod race, that could also make sense. Feedback needed.This PR sits on top of #14174.