Consistently use `Ordering::Relaxed` for standalone atomic use cases by christeefy · Pull Request #14190 · astral-sh/uv

christeefy · 2025-06-21T15:14:30Z

Summary

This is a follow-up to #13033 (comment).

The goals of this PR include:

applying a consistent memory ordering for (simple) use cases that doesn't involve synchronization/interaction with other data structures (i.e. atomics in uv-warning and the one introduced in Skip GitHub fast path when rate-limited #13033)
relaxing the memory ordering from the strictest Ordering::SeqCst to Ordering::Relaxed for such use cases.

Test Plan

Unsure of how to test here.

Dependencies

Skip GitHub fast path when rate-limited #13033 merged

oconnor663

Nice, I've thought about doing the same the last time I looked at this code. (Which was also the first time 😄) What do you think about making the same change to uv_configuration::RAYON_PARALLELISM in this PR? (That is, crates/uv/src/lib.rs and crates/uv-configuration/src/threading.rs.)

christeefy · 2025-06-23T20:41:12Z

I think RAYON_PARALLELISM can be set to Ordering::Relaxed as well.

Here's my thinking (feel free to correct me):

uv_configuration::RAYON_PARALLELISM.store in lib.rs is an independent storing of user configuration
It is stored at the start of program execution, much earlier than when the rayon thread pool is created.

oconnor663

CI flake is a known issue, unrelated.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.7.14` -> `0.7.16` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.7.16`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0716) [Compare Source](astral-sh/uv@0.7.15...0.7.16) ##### Python - Add Python 3.14.0b3 See the [`python-build-standalone` release notes](https://github.com/astral-sh/python-build-standalone/releases/tag/20250626) for more details. ##### Enhancements - Include path or URL when failing to convert in lockfile ([#14292](astral-sh/uv#14292)) - Warn when `~=` is used as a Python version specifier without a patch version ([#14008](astral-sh/uv#14008)) ##### Preview features - Ensure preview default Python installs are upgradeable ([#14261](astral-sh/uv#14261)) ##### Performance - Share workspace cache between lock and sync operations ([#14321](astral-sh/uv#14321)) ##### Bug fixes - Allow local indexes to reference remote files ([#14294](astral-sh/uv#14294)) - Avoid rendering desugared prefix matches in error messages ([#14195](astral-sh/uv#14195)) - Avoid using path URL for workspace Git dependencies in `requirements.txt` ([#14288](astral-sh/uv#14288)) - Normalize index URLs to remove trailing slash ([#14245](astral-sh/uv#14245)) - Respect URL-encoded credentials in redirect location ([#14315](astral-sh/uv#14315)) - Lock the source tree when running setuptools, to protect concurrent builds ([#14174](astral-sh/uv#14174)) ##### Documentation - Note that GCP Artifact Registry download URLs must have `/simple` component ([#14251](astral-sh/uv#14251)) ### [`v0.7.15`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0715) [Compare Source](astral-sh/uv@0.7.14...0.7.15) ##### Enhancements - Consistently use `Ordering::Relaxed` for standalone atomic use cases ([#14190](astral-sh/uv#14190)) - Warn on ambiguous relative paths for `--index` ([#14152](astral-sh/uv#14152)) - Skip GitHub fast path when rate-limited ([#13033](astral-sh/uv#13033)) - Preserve newlines in `schema.json` descriptions ([#13693](astral-sh/uv#13693)) ##### Bug fixes - Add check for using minor version link when creating a venv on Windows ([#14252](astral-sh/uv#14252)) - Strip query parameters when parsing source URL ([#14224](astral-sh/uv#14224)) ##### Documentation - Add a link to PyPI FAQ to clarify what per-project token is ([#14242](astral-sh/uv#14242)) ##### Preview features - Allow symlinks in the build backend ([#14212](astral-sh/uv#14212)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ghcr.io/astral-sh/uv](https://github.com/astral-sh/uv) | final | patch | `0.7.13` -> `0.7.15` | --- ### Release Notes <details> <summary>astral-sh/uv (ghcr.io/astral-sh/uv)</summary> ### [`v0.7.15`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0715) [Compare Source](astral-sh/uv@0.7.14...0.7.15) ##### Enhancements - Consistently use `Ordering::Relaxed` for standalone atomic use cases ([#14190](astral-sh/uv#14190)) - Warn on ambiguous relative paths for `--index` ([#14152](astral-sh/uv#14152)) - Skip GitHub fast path when rate-limited ([#13033](astral-sh/uv#13033)) - Preserve newlines in `schema.json` descriptions ([#13693](astral-sh/uv#13693)) ##### Bug fixes - Add check for using minor version link when creating a venv on Windows ([#14252](astral-sh/uv#14252)) - Strip query parameters when parsing source URL ([#14224](astral-sh/uv#14224)) ##### Documentation - Add a link to PyPI FAQ to clarify what per-project token is ([#14242](astral-sh/uv#14242)) ##### Preview features - Allow symlinks in the build backend ([#14212](astral-sh/uv#14212)) ### [`v0.7.14`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0714) [Compare Source](astral-sh/uv@0.7.13...0.7.14) ##### Enhancements - Add XPU to `--torch-backend` ([#14172](astral-sh/uv#14172)) - Add ROCm backends to `--torch-backend` ([#14120](astral-sh/uv#14120)) - Remove preview label from `--torch-backend` ([#14119](astral-sh/uv#14119)) - Add `[tool.uv.dependency-groups].mygroup.requires-python` ([#13735](astral-sh/uv#13735)) - Add auto-detection for AMD GPUs ([#14176](astral-sh/uv#14176)) - Show retries for HTTP status code errors ([#13897](astral-sh/uv#13897)) - Support transparent Python patch version upgrades ([#13954](astral-sh/uv#13954)) - Warn on empty index directory ([#13940](astral-sh/uv#13940)) - Publish to DockerHub ([#14088](astral-sh/uv#14088)) ##### Performance - Make cold resolves about 10% faster ([#14035](astral-sh/uv#14035)) ##### Bug fixes - Don't use walrus operator in interpreter query script ([#14108](astral-sh/uv#14108)) - Fix handling of changes to `requires-python` ([#14076](astral-sh/uv#14076)) - Fix implied `platform_machine` marker for `...

Use Relaxed memory ordering

9fe2e70

christeefy changed the title ~~Use Relaxed memory ordering~~ Consistently use Ordering::Relaxed for standalone atomic use cases Jun 21, 2025

christeefy mentioned this pull request Jun 21, 2025

Skip GitHub fast path when rate-limited #13033

Merged

christeefy marked this pull request as draft June 21, 2025 15:44

konstin assigned oconnor663 Jun 22, 2025

konstin requested a review from oconnor663 June 22, 2025 13:55

Re-trigger CI

fde9083

christeefy marked this pull request as ready for review June 22, 2025 19:30

oconnor663 requested changes Jun 23, 2025

View reviewed changes

konstin added the enhancement New feature or improvement to existing functionality label Jun 23, 2025

Update memory ordering for RAYON_PARALLELISM

3646bdf

christeefy requested a review from oconnor663 June 23, 2025 20:42

oconnor663 approved these changes Jun 23, 2025

View reviewed changes

Re-trigger CI

993ca5c

oconnor663 merged commit 9fba7a4 into astral-sh:main Jun 24, 2025
87 checks passed

christeefy deleted the consistent-mem-ordering branch June 24, 2025 19:30

BrewTestBot mentioned this pull request Jun 25, 2025

uv 0.7.15 Homebrew/homebrew-core#228105

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Consistently use `Ordering::Relaxed` for standalone atomic use cases#14190

Consistently use `Ordering::Relaxed` for standalone atomic use cases#14190
oconnor663 merged 4 commits intoastral-sh:mainfrom
christeefy:consistent-mem-ordering

christeefy commented Jun 21, 2025 •

edited

Loading

Uh oh!

oconnor663 left a comment

Uh oh!

christeefy commented Jun 23, 2025 •

edited

Loading

Uh oh!

oconnor663 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

christeefy commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Dependencies

Uh oh!

oconnor663 left a comment

Choose a reason for hiding this comment

Uh oh!

christeefy commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oconnor663 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

christeefy commented Jun 21, 2025 •

edited

Loading

christeefy commented Jun 23, 2025 •

edited

Loading