Skip to content

Comments

Fix benchmark compilation failure: cannot find attribute clap in this scope#14128

Merged
jtfmumm merged 1 commit intomainfrom
jtfm/fix-torch-failure
Jun 18, 2025
Merged

Fix benchmark compilation failure: cannot find attribute clap in this scope#14128
jtfmumm merged 1 commit intomainfrom
jtfm/fix-torch-failure

Conversation

@jtfmumm
Copy link
Contributor

@jtfmumm jtfmumm commented Jun 18, 2025

Two benchmark jobs were failing with error: cannot find attribute clap in this scope based on #14120. This updates the recently added #[clap(name = rocm... lines to use cfg_attr(feature = "clap",.

@jtfmumm jtfmumm added the bug Something isn't working label Jun 18, 2025
@jtfmumm jtfmumm temporarily deployed to uv-test-registries June 18, 2025 13:47 — with GitHub Actions Inactive
@konstin
Copy link
Member

konstin commented Jun 18, 2025

Should those be #[cfg_attr(feature = "clap", instead? Otherwise we still have the implicit required clap dependency.

@jtfmumm jtfmumm force-pushed the jtfm/fix-torch-failure branch from ab60ca0 to 7d097e9 Compare June 18, 2025 13:55
@jtfmumm jtfmumm changed the title Handle clap feature in uv-bench to prevent CI failure Fix benchmark compilation failure: cannot find attribute clap in this scope Jun 18, 2025
@jtfmumm jtfmumm temporarily deployed to uv-test-registries June 18, 2025 13:57 — with GitHub Actions Inactive
@jtfmumm
Copy link
Contributor Author

jtfmumm commented Jun 18, 2025

Should those be #[cfg_attr(feature = "clap", instead? Otherwise we still have the implicit required clap dependency.

Updated

@jtfmumm jtfmumm requested a review from konstin June 18, 2025 14:16
@jtfmumm jtfmumm merged commit 611a13c into main Jun 18, 2025
87 checks passed
@jtfmumm jtfmumm deleted the jtfm/fix-torch-failure branch June 18, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants