Follow-up minor refactoring of transparent Python upgrade code#14029
Merged
jtfmumm merged 2 commits intofeature/transparent-python-upgradesfrom Jun 13, 2025
Merged
Conversation
zanieb
approved these changes
Jun 13, 2025
zanieb
reviewed
Jun 13, 2025
jtfmumm
merged commit 2a0ccc9
into
feature/transparent-python-upgrades
86 checks passed
jtfmumm
added a commit
that referenced
this pull request
Jun 13, 2025
This PR: * renames `PythonMinorVersionLink::symlink_exists()` to `..::exists` * avoids rediscovering installations by chaining together new installations with pre-existing installations when searching for the highest patch per minor version key * renames a couple of related errors and updates their messages to be more specific * renames `create_bin_link` to `create_link_to_executable` * removes a constructor that is no longer used (`PythonMinorVersinLink::from_interpreter()`)
jtfmumm
added a commit
that referenced
this pull request
Jun 13, 2025
This PR: * renames `PythonMinorVersionLink::symlink_exists()` to `..::exists` * avoids rediscovering installations by chaining together new installations with pre-existing installations when searching for the highest patch per minor version key * renames a couple of related errors and updates their messages to be more specific * renames `create_bin_link` to `create_link_to_executable` * removes a constructor that is no longer used (`PythonMinorVersinLink::from_interpreter()`)
jtfmumm
added a commit
that referenced
this pull request
Jun 13, 2025
This PR: * renames `PythonMinorVersionLink::symlink_exists()` to `..::exists` * avoids rediscovering installations by chaining together new installations with pre-existing installations when searching for the highest patch per minor version key * renames a couple of related errors and updates their messages to be more specific * renames `create_bin_link` to `create_link_to_executable` * removes a constructor that is no longer used (`PythonMinorVersinLink::from_interpreter()`)
jtfmumm
added a commit
that referenced
this pull request
Jun 16, 2025
This PR: * renames `PythonMinorVersionLink::symlink_exists()` to `..::exists` * avoids rediscovering installations by chaining together new installations with pre-existing installations when searching for the highest patch per minor version key * renames a couple of related errors and updates their messages to be more specific * renames `create_bin_link` to `create_link_to_executable` * removes a constructor that is no longer used (`PythonMinorVersinLink::from_interpreter()`)
jtfmumm
added a commit
that referenced
this pull request
Jun 17, 2025
This PR: * renames `PythonMinorVersionLink::symlink_exists()` to `..::exists` * avoids rediscovering installations by chaining together new installations with pre-existing installations when searching for the highest patch per minor version key * renames a couple of related errors and updates their messages to be more specific * renames `create_bin_link` to `create_link_to_executable` * removes a constructor that is no longer used (`PythonMinorVersinLink::from_interpreter()`)
jtfmumm
added a commit
that referenced
this pull request
Jun 18, 2025
This PR: * renames `PythonMinorVersionLink::symlink_exists()` to `..::exists` * avoids rediscovering installations by chaining together new installations with pre-existing installations when searching for the highest patch per minor version key * renames a couple of related errors and updates their messages to be more specific * renames `create_bin_link` to `create_link_to_executable` * removes a constructor that is no longer used (`PythonMinorVersinLink::from_interpreter()`)
jtfmumm
added a commit
that referenced
this pull request
Jun 20, 2025
This PR: * renames `PythonMinorVersionLink::symlink_exists()` to `..::exists` * avoids rediscovering installations by chaining together new installations with pre-existing installations when searching for the highest patch per minor version key * renames a couple of related errors and updates their messages to be more specific * renames `create_bin_link` to `create_link_to_executable` * removes a constructor that is no longer used (`PythonMinorVersinLink::from_interpreter()`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
PythonMinorVersionLink::symlink_exists()to..::existscreate_bin_linktocreate_link_to_executablePythonMinorVersinLink::from_interpreter())