Skip to content

Comments

Rename DirectorySymlink to the more descriptive PythonMinorVersionLink#13953

Merged
jtfmumm merged 2 commits intofeature/transparent-python-upgradesfrom
jtfm/rename-directory-symlink
Jun 10, 2025
Merged

Rename DirectorySymlink to the more descriptive PythonMinorVersionLink#13953
jtfmumm merged 2 commits intofeature/transparent-python-upgradesfrom
jtfm/rename-directory-symlink

Conversation

@jtfmumm
Copy link
Contributor

@jtfmumm jtfmumm commented Jun 10, 2025

The DirectorySymlink struct assumes that it will be a Python minor version link, so this renaming makes the intention clearer.

@jtfmumm jtfmumm added the internal A refactor or improvement that is not user-facing label Jun 10, 2025
@jtfmumm jtfmumm requested a review from zanieb June 10, 2025 18:35
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably include Python in the name, but don't feel strongly.

@jtfmumm jtfmumm changed the title Rename DirectorySymlink to the more descriptive MinorVersionLink Rename DirectorySymlink to the more descriptive PythonMinorVersionLink Jun 10, 2025
@jtfmumm jtfmumm merged commit 942f47c into feature/transparent-python-upgrades Jun 10, 2025
86 checks passed
@jtfmumm jtfmumm deleted the jtfm/rename-directory-symlink branch June 10, 2025 18:52
jtfmumm added a commit that referenced this pull request Jun 11, 2025
…Link` (#13953)

The `DirectorySymlink` struct assumes that it will be a Python minor
version link, so this renaming makes the intention clearer.
jtfmumm added a commit that referenced this pull request Jun 13, 2025
…Link` (#13953)

The `DirectorySymlink` struct assumes that it will be a Python minor
version link, so this renaming makes the intention clearer.
jtfmumm added a commit that referenced this pull request Jun 17, 2025
…Link` (#13953)

The `DirectorySymlink` struct assumes that it will be a Python minor
version link, so this renaming makes the intention clearer.
jtfmumm added a commit that referenced this pull request Jun 18, 2025
…Link` (#13953)

The `DirectorySymlink` struct assumes that it will be a Python minor
version link, so this renaming makes the intention clearer.
jtfmumm added a commit that referenced this pull request Jun 20, 2025
…Link` (#13953)

The `DirectorySymlink` struct assumes that it will be a Python minor
version link, so this renaming makes the intention clearer.
@zanieb zanieb mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants