Make DisplaySafeUrlRef Copy and other minor PR follow-ups#13683
Merged
Conversation
jtfmumm
force-pushed
the
jtfm/display-safe-url-followup
branch
from
e099a02 to
3164170
Compare
jtfmumm
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a few review follow-ups from #13560. In particular, it
DisplaySafeUrlRefimplementCopyso that it can be passed by value.to_string_with_credentialsmethods withdisplayable_with_credentials, returning animpl Displayinstead ofStringfor greater flexibility.DisplaySafeUrlandDisplaySafeUrlRefDebugimplementations to match the underlyingUrlDebugimplementation (with the exception that credentials are masked).DisplaySafeUrl::from(Url::from_file_pathwithDisplaySafeUrl::from_file_path