Conversation
konstin
added
internal
konstin
force-pushed
the
konsti/basic-retry-tests
branch
2 times, most recently
from
58b128c to
93bbfd1
Compare
konstin
added a commit
that referenced
this pull request
May 23, 2025
Currently, it is not possible to set a custom Python downloads JSON on Windows, as Windows paths can be valid URLs.
```rust
use url::Url;
fn main() {
dbg!(Url::parse(r"C:\Users\Ferris\download.json"));
}
```
Tested by #13585 (where it is currently failing CI)
konstin
added a commit
that referenced
this pull request
May 26, 2025
Currently, it is not possible to set a custom Python downloads JSON on Windows, as Windows paths can be valid URLs.
```rust
use url::Url;
fn main() {
dbg!(Url::parse(r"C:\Users\Ferris\download.json"));
}
```
Tested by #13585 (where it is currently failing CI)
konstin
added a commit
that referenced
this pull request
May 26, 2025
Currently, it is not possible to set a custom Python downloads JSON on Windows, as Windows paths can be valid URLs.
```rust
use url::Url;
fn main() {
dbg!(Url::parse(r"C:\Users\Ferris\download.json"));
}
```
Tested by #13585 (where it is currently failing CI)
konstin
added a commit
that referenced
this pull request
May 26, 2025
Currently, it is not possible to set a custom Python downloads JSON on Windows, as Windows paths can be valid URLs.
```rust
use url::Url;
fn main() {
dbg!(Url::parse(r"C:\Users\Ferris\download.json"));
}
```
Tested by #13585 (where it is currently failing CI)
konstin
added a commit
that referenced
this pull request
May 28, 2025
Currently, it is not possible to set a custom Python downloads JSON on Windows, as Windows paths can be valid URLs.
```rust
use url::Url;
fn main() {
dbg!(Url::parse(r"C:\Users\Ferris\download.json"));
}
```
Tested by #13585 (where it is currently failing CI)
konstin
added a commit
that referenced
this pull request
May 28, 2025
Currently, it is not possible to set a custom Python downloads JSON on Windows, as Windows paths can be valid URLs.
```rust
use url::Url;
fn main() {
dbg!(Url::parse(r"C:\Users\Ferris\download.json"));
}
```
Tested by #13585 (where it is currently failing CI)
zanieb
pushed a commit
that referenced
this pull request
May 28, 2025
Currently, it is not possible to set a custom Python downloads JSON on
Windows, as Windows paths can be valid URLs.
```rust
use url::Url;
fn main() {
dbg!(Url::parse(r"C:\Users\Ferris\download.json"));
}
```
Tested by #13585 (where it is
currently failing CI).
konstin
force-pushed
the
konsti/basic-retry-tests
branch
from
93bbfd1 to
0309430
Compare
Add basic tests for error messages on retryable network errors. This test mod is intended to grow to ensure that we handle retryable errors correctly and that we show the appropriate error message if we failed after retrying. The starter tests show some common cases we've seen download errors in: simple and find links indexes, file downloads and Python installs.
konstin
force-pushed
the
konsti/basic-retry-tests
branch
from
0309430 to
ca60ba7
Compare
jtfmumm
reviewed
Jun 9, 2025
| async fn simple_http_500() { | ||
| let context = TestContext::new("3.12"); | ||
|
|
||
| let server = MockServer::start().await; |
Contributor
There was a problem hiding this comment.
It looks like you can break this out into a separate function for use across these tests and just return the URI.
Contributor
There was a problem hiding this comment.
You've already broken this out in the follow up PR so it may not be necessary here if you've touched all these cases.
jtfmumm
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic tests for error messages on retryable network errors.
This test mod is intended to grow to ensure that we handle retryable errors correctly and that we show the appropriate error message if we failed after retrying.
The starter tests show some common cases we've seen download errors in: simple and find links indexes, file downloads and Python installs.
For
io::Errorfault injection to test the reqwestErrpath besides the HTTP status codeOkpath, see LukeMathWalker/wiremock-rs#149.