Skip to content

Comments

Add more default group tests and fix default groups for uv add#13182

Merged
Gankra merged 1 commit intoastral-sh:mainfrom
blueraft:tests-default-groups
Apr 28, 2025
Merged

Add more default group tests and fix default groups for uv add#13182
Gankra merged 1 commit intoastral-sh:mainfrom
blueraft:tests-default-groups

Conversation

@blueraft
Copy link
Contributor

@blueraft blueraft commented Apr 28, 2025

Summary

Brings in a bug fix for uv add w.r.t default groups from #12964, see comment: #12964 (comment)

Adds additional test coverage for default groups in run, remove, add.

Test Plan

cargo test

@konstin konstin requested a review from Gankra April 28, 2025 16:27
Copy link
Contributor

@Gankra Gankra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rad!

@blueraft blueraft force-pushed the tests-default-groups branch from 985d9d2 to cd6cca7 Compare April 28, 2025 18:05
@blueraft
Copy link
Contributor Author

not sure why that test failed, I'll close and re-open

@blueraft blueraft closed this Apr 28, 2025
@blueraft blueraft reopened this Apr 28, 2025
@Gankra Gankra merged commit 4680c9b into astral-sh:main Apr 28, 2025
168 of 169 checks passed
@Gankra Gankra added the internal A refactor or improvement that is not user-facing label Apr 28, 2025
@blueraft blueraft deleted the tests-default-groups branch April 29, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants