Temporarily remove bogus redirect test#13076
Merged
charliermarsh merged 1 commit intomainfrom Apr 23, 2025
Merged
Conversation
jtfmumm
added a commit
that referenced
this pull request
Apr 24, 2025
#13088) This PR restores the `bogus_redirect` test that was non-deterministically hanging (reverting #13076). Mismatched package and distribution names were causing uv to hang prior to #12917 (which added the `bogus_redirect` test). But with that fix, uv was only checking for mismatched package names on the main thread (and not the resolver thread). This allowed for a race condition which would prevent uv from ever doing the check, triggering the original hang condition. This PR adds the check to the resolver thread to prevent this race condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This needs to be made more reliable.