Refactor ExtraSpecification to support default-extras#12964
Merged
Gankra merged 1 commit intoastral-sh:mainfrom Apr 28, 2025
Merged
Refactor ExtraSpecification to support default-extras#12964Gankra merged 1 commit intoastral-sh:mainfrom
ExtraSpecification to support default-extras#12964Gankra merged 1 commit intoastral-sh:mainfrom
Conversation
Gankra
approved these changes
Apr 25, 2025
Contributor
Gankra
left a comment
Gankra
left a comment
There was a problem hiding this comment.
This looks great, I left some notes for minor potential errors.
blueraft
force-pushed
the
refactor-extra-specification
branch
from
d9e93d7 to
a8cf855
Compare
blueraft
force-pushed
the
refactor-extra-specification
branch
from
a8cf855 to
440db64
Compare
Contributor
|
@blueraft any outstanding concerns with the PR from you, or ready to land? |
Contributor
|
Alternatively I can just close the PR and we focus on the main one? |
Contributor
Author
|
No concerns on my side! I think we can land this and tweak stuff in the main one |
Gankra
pushed a commit
that referenced
this pull request
Apr 28, 2025
) ## Summary Brings in a bug fix for `uv add` w.r.t default groups from #12964, see comment: #12964 (comment) Adds additional test coverage for default groups in `run`, `remove`, `add`. ## Test Plan `cargo test`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #8607. This is a pure refactor aimed at paving the way for supporting the
default-extrasconfiguration in thepyproject.tomlfile.The
ExtraSpecificationstruct has been refactored to align more closely with theDependencyGroupsstruct.Test Plan
Existing tests.