Draft
Conversation
Signed-off-by: Abhi Agarwal <[email protected]>
Signed-off-by: Abhi Agarwal <[email protected]>
Author
|
|
|
come from #1681, any update ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a rudimentary
uv pip wheelcommand. This is simply a repackageduv pip installthat short-circuits at the actual install step and instead takes the cached wheels and zips them up. Marked as draft because I don't really like my implementation, it's a bit messy and duplicates a lot ofuv pip install, and there's questions about the semantics ofpip wheelthat I don't have enough knowledge to answer.Resolves #1681
TODO:
uv pip wheelanduv pip installresolving dependenciesis really howpip wheelis supposed to behaveuv-build-backend)(On the last point: I can
uv pip wheeland install said wheels, and they're identical touv pip wheel, sans the records being slightly different due to console scripts not being included. I do think this is an actual bug though, which is why I want to use the logic inuv-build-backendwhich has already solved this, though it will need to be in a new crate).