Add support for pre-releases to Python platform key regex#12380
Merged
Conversation
charliermarsh
approved these changes
Mar 21, 2025
Member
charliermarsh
left a comment
charliermarsh
left a comment
There was a problem hiding this comment.
Do you want to explicitly match on the allowed pre-release components (rather than accepting any [a-z]?
zanieb
added a commit
that referenced
this pull request
Mar 23, 2025
I need to edit this thing and it's a nightmare as written. See #12380
Member
Author
It's a fair question, it didn't seem worth the effort but it's not hard so, sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for more test cases on top of #12374