Display the built file name instead of the canonicalized name in `uv build` by jtfmumm · Pull Request #11593 · astral-sh/uv

jtfmumm · 2025-02-18T11:04:55Z

We keep the raw filename (prior to parsing/normalization) on the BuildMessage so we can display it.

konstin · 2025-02-18T11:45:22Z

crates/uv/src/commands/build_frontend.rs

@@ -1140,13 +1148,17 @@ enum BuildMessage {
    Build {
        /// The name of the built distribution.
        filename: DistFilename,


Do we still need the filename field now that we have the raw name?

There are a couple places that grab the .version() and there's this line:

let path = output_dir.join(sdist_build.filename().to_string());

I wasn't sure if it would be safe to replace it for that path.

I would expect that let path = output_dir.join(sdist_build.filename().to_string needs to use the raw filename since we're trying to read from that path. Can we check why that isn't failing today?

I added a test to build.rs that fails because of this line. The test passes after updating to use the raw filename.

charliermarsh · 2025-02-19T22:34:28Z

crates/uv/src/commands/build_frontend.rs

+    }
+
+    /// The filename of the wheel or source distribution before normalization.
+    fn raw_filename(&self) -> &String {


I'd suggest returning &str here? I think it's somewhat uncommon to return &String since it's strictly less flexible (you can always get an &str from an &String, but you can't go the other way around).

charliermarsh · 2025-02-19T22:35:34Z

crates/uv/src/commands/build_frontend.rs

        match self {
            BuildMessage::Build {
-                filename,
+                raw_filename: raw_name,


Nit: this seems like a potentially unnecessary assignment since they're so similar (but not blocking obviously, up to you).

Yeah that was just an oversight

charliermarsh · 2025-02-19T22:36:15Z

I linked the other issue here too, to close it out on merge.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.6.0` -> `0.6.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.6.3`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#063) [Compare Source](astral-sh/uv@0.6.2...0.6.3) ##### Enhancements - Allow quotes around command-line options in `requirement.txt files` ([#11644](astral-sh/uv#11644)) - Initialize PEP 723 script in `uv lock --script` ([#11717](astral-sh/uv#11717)) ##### Configuration - Accept multiple `.env` files in `UV_ENV_FILE` ([#11665](astral-sh/uv#11665)) ##### Performance - Reduce overhead in converting resolutions ([#11660](astral-sh/uv#11660)) - Use `SmallString` on `Hashes` ([#11756](astral-sh/uv#11756)) - Use a `Box` for `Yanked` on `File` ([#11755](astral-sh/uv#11755)) - Use a `SmallString` for the `Yanked` enum ([#11715](astral-sh/uv#11715)) - Use boxed slices for hash vector ([#11714](astral-sh/uv#11714)) - Use install concurrency for bytecode compilation too ([#11615](astral-sh/uv#11615)) ##### Bug fixes - Avoid installing duplicate dependencies across conflicting groups ([#11653](astral-sh/uv#11653)) - Check subdirectory existence after cache heal ([#11719](astral-sh/uv#11719)) - Include uppercase platforms for Windows wheels ([#11681](astral-sh/uv#11681)) - Respect existing PEP 723 script settings in `uv add` ([#11716](astral-sh/uv#11716)) - Reuse refined interpreter to create tool environment ([#11680](astral-sh/uv#11680)) - Skip removed directories during bytecode compilation ([#11633](astral-sh/uv#11633)) - Support conflict markers in `uv export` ([#11643](astral-sh/uv#11643)) - Treat lockfile as outdated if (empty) extras are added ([#11702](astral-sh/uv#11702)) - Display path separators as backslashes on Windows ([#11667](astral-sh/uv#11667)) - Display the built file name instead of the canonicalized name in `uv build` ([#11593](astral-sh/uv#11593)) - Fix message when there are no buildable packages ([#11722](astral-sh/uv#11722)) - Re-allow HTTP schemes for Git dependencies ([#11687](astral-sh/uv#11687)) ##### Documentation - Add anchor links to arguments and options in the CLI reference ([#11754](astral-sh/uv#11754)) - Add link to environment marker specification ([#11748](astral-sh/uv#11748)) - Fix missing a closing bracket in the `cache-keys` setting ([#11669](astral-sh/uv#11669)) - Remove the last edited date from documentation pages ([#11753](astral-sh/uv#11753)) - Fix readme typo ([#11742](astral-sh/uv#11742)) ### [`v0.6.2`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#062) [Compare Source](astral-sh/uv@0.6.1...0.6.2) ##### Enhancements - Add support for constraining build dependencies with `tool.uv.build-constraint-dependencies` ([#11585](astral-sh/uv#11585)) - Sort dependency group keys when adding new group ([#11591](astral-sh/uv#11591)) ##### Performance - Use an `Arc` for index URLs ([#11586](astral-sh/uv#11586)) ##### Bug fixes - Allow use of x86-64 Python on ARM Windows ([#11625](astral-sh/uv#11625)) - Fix an issue where conflict markers could instigate a very large lock file ([#11293](astral-sh/uv#11293)) - Fix duplicate packages with multiple conflicting extras declared ([#11513](astral-sh/uv#11513)) - Respect color settings for log messages ([#11604](astral-sh/uv#11604)) - Eagerly reject unsupported Git schemes ([#11514](astral-sh/uv#11514)) ##### Documentation - Add documentation for specifying Python versions in tool commands ([#11598](astral-sh/uv#11598)) ### [`v0.6.1`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#061) [Compare Source](astral-sh/uv@0.6.0...0.6.1) ##### Enhancements - Allow users to mark platforms as "required" for wheel coverage ([#10067](astral-sh/uv#10067)) - Warn for builds in non-build and workspace root pyproject.toml ([#11394](astral-sh/uv#11394)) ##### Bug fixes - Add `--all` to `uvx --reinstall` message ([#11535](astral-sh/uv#11535)) - Fallback to `GET` on HTTP 400 when attempting to use range requests for wheel download ([#11539](astral-sh/uv#11539)) - Prefer local variants in preference selection ([#11546](astral-sh/uv#11546)) - Respect verbatim executable name in `uvx` ([#11524](astral-sh/uv#11524)) ##### Documentation - Add documentation for required environments ([#11542](astral-sh/uv#11542)) - Note that `main.py` used to be `hello.py` ([#11519](astral-sh/uv#11519)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

…build` (astral-sh#11593) We keep the raw filename (prior to parsing/normalization) on the `BuildMessage` so we can display it. Closes astral-sh#11103. Closes astral-sh#11635.

jtfmumm force-pushed the jtfm/display-real-filename branch from 3235f50 to 3496e94 Compare February 18, 2025 11:05

Display built file name instead of canonicalized name in uv build

45e7cf9

jtfmumm force-pushed the jtfm/display-real-filename branch from 3496e94 to 45e7cf9 Compare February 18, 2025 11:06

konstin reviewed Feb 18, 2025

View reviewed changes

zanieb mentioned this pull request Feb 19, 2025

uv build is looking for the wrong sdist file #11635

Closed

Use non-normalized filename for path

c60488e

jtfmumm mentioned this pull request Feb 19, 2025

Possibly spurious Windows test failure #11638

Open

charliermarsh reviewed Feb 19, 2025

View reviewed changes

charliermarsh approved these changes Feb 19, 2025

View reviewed changes

Use --no-build-logs on build test

714bf48

jtfmumm force-pushed the jtfm/display-real-filename branch from 7155ea3 to 714bf48 Compare February 20, 2025 07:57

jtfmumm merged commit ab551ea into main Feb 20, 2025
73 checks passed

jtfmumm deleted the jtfm/display-real-filename branch February 20, 2025 08:11

BrewTestBot mentioned this pull request Feb 24, 2025

uv 0.6.3 Homebrew/homebrew-core#208817

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Display the built file name instead of the canonicalized name in `uv build`#11593

Display the built file name instead of the canonicalized name in `uv build`#11593
jtfmumm merged 3 commits intomainfrom
jtfm/display-real-filename

jtfmumm commented Feb 18, 2025 •

edited by charliermarsh

Loading

Uh oh!

konstin Feb 18, 2025 •

edited

Loading

Uh oh!

jtfmumm Feb 18, 2025

Uh oh!

charliermarsh Feb 18, 2025

Uh oh!

jtfmumm Feb 19, 2025

Uh oh!

charliermarsh Feb 19, 2025

Uh oh!

charliermarsh Feb 19, 2025

Uh oh!

jtfmumm Feb 20, 2025 •

edited

Loading

Uh oh!

charliermarsh commented Feb 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

jtfmumm commented Feb 18, 2025 • edited by charliermarsh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

konstin Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtfmumm Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

charliermarsh Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

jtfmumm Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

charliermarsh Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

charliermarsh Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

jtfmumm Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

charliermarsh commented Feb 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jtfmumm commented Feb 18, 2025 •

edited by charliermarsh

Loading

konstin Feb 18, 2025 •

edited

Loading

jtfmumm Feb 20, 2025 •

edited

Loading