Allow fallback to Python download on non-critical discovery errors by zanieb · Pull Request #10908 · astral-sh/uv

zanieb · 2025-01-23T18:10:30Z

In #10716, I broke fallback to downloading Python versions by throwing a different error kind.

zanieb · 2025-01-23T18:12:11Z

crates/uv-python/src/installation.rs

+            // If we raised a non-critical error, we should attempt a download
+            Error::Discovery(ref err) if !err.is_critical() => {}


This is the key change. The rest is just refactoring so we can match on multiple error types cleanly.

zanieb · 2025-01-23T18:12:53Z

I want to add test coverage, but reviews are welcome — this is important to get out today.

zanieb · 2025-01-23T18:14:33Z

crates/uv-python/src/installation.rs

-        match Self::find(request, environments, preference, cache) {
-            Ok(venv) => Ok(venv),
-            // If missing and allowed, perform a fetch
-            Err(Error::MissingPython(err))


#10716 added a throw of Error::Discovery instead of a PythonNotFound error (which is mapped to MissingPython transparently here) which means we no longer fallback.

Ideally we'd implement #10716 higher up, like here? but couldn't think of a clean way to do that.

ceejatec · 2025-01-24T01:03:27Z

Thanks for this! We hit this bug just today, and I was literally in the process of writing up a bug report ten minutes ago and couldn't figure out how to reproduce it. Turns out we hit the bug with uv 0.5.23 an hour ago, but when I was working on a reproducer it got the fresh-from-the-oven uv 0.5.24.

zanieb · 2025-01-24T01:48:02Z

That's great to hear! I figured someone else would hit it quickly 😬

jramcast · 2025-01-24T10:04:08Z

Thank you for the quick fix! All is working nicely now.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.22` -> `0.5.24` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.5.24`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0524) [Compare Source](astral-sh/uv@0.5.23...0.5.24) ##### Enhancements - Improve determinism of resolution by always setting package priorities ([#10853](astral-sh/uv#10853)) - Upgrade to `cargo-dist` 0.28.0; improves several installer behaviors ([#10884](astral-sh/uv#10884)) ##### Performance - Remove dependencies clone in resolver ([#10880](astral-sh/uv#10880)) - Use Hashbrown's raw entry API to reduce hashes and clone in resolver priority determination ([#10881](astral-sh/uv#10881)) ##### Bug fixes - Allow fallback to Python download on non-critical discovery errors ([#10908](astral-sh/uv#10908)) ##### Preview features - Register managed Python version with the Windows Registry (PEP 514) ([#10634](astral-sh/uv#10634)) ##### Documentation - Improve documentation for some environment variables ([#10887](astral-sh/uv#10887)) - Add git subdirectory example ([#10894](astral-sh/uv#10894)) ### [`v0.5.23`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0523) [Compare Source](astral-sh/uv@0.5.22...0.5.23) ##### Enhancements - Add `--refresh` to `uv venv` ([#10834](astral-sh/uv#10834)) - Add `--no-default-groups` command-line flag ([#10618](astral-sh/uv#10618)) ##### Bug fixes - Sort extras and groups when comparing lockfile requirements ([#10856](astral-sh/uv#10856)) - Include `commit_id` and `requested_revision` in `direct_url.json` ([#10862](astral-sh/uv#10862)) - Invalidate lockfile when static versions change ([#10858](astral-sh/uv#10858)) - Make GitHub fast path errors non-fatal ([#10859](astral-sh/uv#10859)) - Remove warnings for `--frozen` and `--locked` in `uv run --script` ([#10840](astral-sh/uv#10840)) - Resolve `find-links` paths relative to the configuration file ([#10827](astral-sh/uv#10827)) - Respect visitation order for proxy packages ([#10833](astral-sh/uv#10833)) - Treat version mismatch errors as non-fatal in fast paths ([#10860](astral-sh/uv#10860)) - Mark `--locked` and `--upgrade` are conflicting ([#10836](astral-sh/uv#10836)) - Relax error checking around unconditional enabling of conflicting extras ([#10875](astral-sh/uv#10875)) ##### Documentation - Reduce ambiguity in conflicting extras example ([#10877](astral-sh/uv#10877)) - Update pre-commit documentation ([#10756](astral-sh/uv#10756)) ##### Error messages - Error when workspace contains conflicting Python requirements ([#10841](astral-sh/uv#10841)) - Improve uvx error message when uv is missing ([#9745](astral-sh/uv#9745)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

…the PATH (#11030) Closes #10978 The root cause is the same as #10908 — I should have been more careful with the original change.

zanieb added the bug Something isn't working label Jan 23, 2025

zanieb force-pushed the zb/find-download branch from c1de56e to 41c10ea Compare January 23, 2025 18:10

zanieb changed the title ~~zb/find download~~ Allow fallback to Python download on non-critical discovery errors Jan 23, 2025

zanieb commented Jan 23, 2025

View reviewed changes

zanieb requested review from Gankra and charliermarsh January 23, 2025 18:12

zanieb marked this pull request as ready for review January 23, 2025 18:13

zanieb commented Jan 23, 2025

View reviewed changes

Gankra approved these changes Jan 23, 2025

View reviewed changes

charliermarsh approved these changes Jan 23, 2025

View reviewed changes

zanieb mentioned this pull request Jan 23, 2025

Add test case for automatic installs #10913

Merged

zanieb changed the base branch from main to zb/install-auto-test January 23, 2025 21:08

zanieb force-pushed the zb/find-download branch from 41c10ea to c6380cd Compare January 23, 2025 21:08

zanieb force-pushed the zb/install-auto-test branch 5 times, most recently from e7d5324 to e9043f2 Compare January 23, 2025 22:13

Base automatically changed from zb/install-auto-test to main January 23, 2025 22:21

Allow fallback to Python download on non-critical discovery errors

2817770

zanieb force-pushed the zb/find-download branch from c6380cd to 2817770 Compare January 23, 2025 22:29

zanieb enabled auto-merge (squash) January 23, 2025 22:35

zanieb merged commit cbf6d5a into main Jan 23, 2025
72 checks passed

zanieb deleted the zb/find-download branch January 23, 2025 22:37

BrewTestBot mentioned this pull request Jan 24, 2025

uv 0.5.24 Homebrew/homebrew-core#205366

Merged

This was referenced Jan 28, 2025

New version of uv fails to build universal requirements for python version system does not have #10978

Closed

Fix best-interpreter lookups when there is an invalid interpreter in the PATH #11030

Merged

zanieb added a commit that referenced this pull request Jan 28, 2025

Fix best-interpreter lookups when there is an invalid interpreter in …

e26affd

…the PATH (#11030) Closes #10978 The root cause is the same as #10908 — I should have been more careful with the original change.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Allow fallback to Python download on non-critical discovery errors#10908

Allow fallback to Python download on non-critical discovery errors#10908
zanieb merged 1 commit intomainfrom
zb/find-download

zanieb commented Jan 23, 2025 •

edited

Loading

Uh oh!

zanieb Jan 23, 2025

Uh oh!

zanieb commented Jan 23, 2025

Uh oh!

zanieb Jan 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

ceejatec commented Jan 24, 2025

Uh oh!

zanieb commented Jan 24, 2025

Uh oh!

jramcast commented Jan 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		// If we raised a non-critical error, we should attempt a download
		Error::Discovery(ref err) if !err.is_critical() => {}

Comments

Conversation

zanieb commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zanieb Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

zanieb commented Jan 23, 2025

Uh oh!

zanieb Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ceejatec commented Jan 24, 2025

Uh oh!

zanieb commented Jan 24, 2025

Uh oh!

jramcast commented Jan 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zanieb commented Jan 23, 2025 •

edited

Loading

zanieb Jan 23, 2025 •

edited

Loading