Avoiding initiating forks when applying constraints to markers#10489
Closed
charliermarsh wants to merge 2 commits intomainfrom
Closed
Avoiding initiating forks when applying constraints to markers#10489charliermarsh wants to merge 2 commits intomainfrom
charliermarsh wants to merge 2 commits intomainfrom
Conversation
Member
Author
|
I'm worried that this will regress error messages. I have another idea for how to fix it, if so... |
charliermarsh
force-pushed
the
charlie/fork-constraints
branch
from
b289679 to
9ff5f54
Compare
Member
Author
|
Yeah this is probably a no-go. |
charliermarsh
added a commit
that referenced
this pull request
Jan 11, 2025
## Summary If you have a dependency with a marker, and you add a constraint, it causes us to _always_ fork, because we represent the constraint as a second dependency with the marker repeated (and, therefore, we have two requirements of the same name, both with markers). I don't think we should fork here -- and in the end it's leading to this undesirable resolution: #10481. I tried to change constraints such that we just _reuse_ and augment the initial requirement, but that has a fairly negative effect on error messages: #10489. So this fix seems a bit better to me. Closes #10481.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10481.