uv-pep440: adds an explicit test for trailing zeros#10362
Merged
BurntSushi merged 1 commit intomainfrom Jan 7, 2025
Merged
Conversation
Basically, this explicitly checks that parsing a `1.2.0` into a `Version` will roundtrip back to a `1.2.0`, and that parsing a `1.2` will roundtrip back to a `1.2`. I think this case is included in the other tests in this module, but this test makes the behavior more clearly intentional I think. Ref #10345
konstin
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, this explicitly checks that parsing a
1.2.0into aVersionwill roundtrip back to a1.2.0, and that parsing a1.2will roundtrip back to a
1.2.I think this case is included in the other tests in this module, but
this test makes the behavior more clearly intentional I think.
Ref #10345