Avoid duplicating backslashes in sysconfig parser#10063
Merged
charliermarsh merged 1 commit intomainfrom Dec 20, 2024
Merged
Conversation
charliermarsh
commented
Dec 20, 2024
| // We don't support octals (e.g., `\ooo`), hexadecimals (e.g., `\xhh`), and | ||
| // named Unicode characters (e.g., `\N{...}`). | ||
| warn!("Unrecognized escape sequence: `{c}`"); | ||
| c |
Member
Author
There was a problem hiding this comment.
I don't think it's necessary to add parsing for these... We know this file doesn't contain these, we generate it.
charliermarsh
force-pushed
the
charlie/backslash
branch
from
5e6b8c6 to
2f69f54
Compare
charliermarsh
commented
Dec 20, 2024
| '\'' => '\'', | ||
| '\"' => '"', | ||
| _ => { | ||
| return Err(Error::UnrecognizedEscape(c)); |
Member
Author
There was a problem hiding this comment.
I don't think it's necessary for us to handle all the cases here. We generate this file, we know it doesn't contain (e.g.) Unicode names.
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Dec 28, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.11` -> `0.5.13` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.5.13`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0513) [Compare Source](astral-sh/uv@0.5.12...0.5.13) ##### Bug fixes - Avoid enforcing URL check on initial publish ([#​10182](astral-sh/uv#10182)) - Fix incorrect mismatched constraints reference ([#​10184](astral-sh/uv#10184)) - Revert "Update `reqwest` ([#​10178](astral-sh/uv#10178))" ([#​10187](astral-sh/uv#10187)) ### [`v0.5.12`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0512) [Compare Source](astral-sh/uv@0.5.11...0.5.12) ##### Enhancements - Support `uv export` for non-project workspaces ([#​10144](astral-sh/uv#10144)) - Set glibc versions for standalone installers ([#​10142](astral-sh/uv#10142)) - Allow environment variables to be included in cache keys ([#​10170](astral-sh/uv#10170)) ##### Preview features - Include extras in `uv-build` `Requires-Dist` metadata ([#​10110](astral-sh/uv#10110)) - Use `shutil.which` for the build backend ([#​10028](astral-sh/uv#10028)) ##### Bug fixes - Always write slash paths to RECORD file ([#​10164](astral-sh/uv#10164)) - Add support for subdirectories in direct URLs in `uv.lock` ([#​10068](astral-sh/uv#10068)) - Avoid duplicating backslashes in sysconfig parser ([#​10063](astral-sh/uv#10063)) - Avoid erroring when subdirectories are provided in `uv add` ([#​10095](astral-sh/uv#10095)) - Backtrack to non-local versions when wheels are missing platform support ([#​10046](astral-sh/uv#10046)) - Fix mirror script to handle newer metadata format ([#​10050](astral-sh/uv#10050)) - Preserve sort when deciding on requirement placement ([#​10078](astral-sh/uv#10078)) - Remove redundant alias in `uv init` CLI ([#​10124](astral-sh/uv#10124)) - Respect sources credentials in non-project workspaces ([#​10125](astral-sh/uv#10125)) - Show non-project dependencies in `uv tree` ([#​10149](astral-sh/uv#10149)) - Strip fragment when storing direct URL ([#​10093](astral-sh/uv#10093)) - Include hashes for local source archives ([#​10080](astral-sh/uv#10080)) ##### Documentation - Fix invalid syntax in some sources examples ([#​10127](astral-sh/uv#10127)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44Mi45IiwidXBkYXRlZEluVmVyIjoiMzkuODMuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We had a bug in our handling of escape sequences that caused us to duplicate backslashes. If you installed repeatedly, we'd keep doubling them, leading to an exponential blowup.
Closes #10060.