Denote required platforms in [tool.uv] metadata#10017
Closed
charliermarsh wants to merge 1 commit intocharlie/incompletefrom
Closed
Denote required platforms in [tool.uv] metadata#10017charliermarsh wants to merge 1 commit intocharlie/incompletefrom
[tool.uv] metadata#10017charliermarsh wants to merge 1 commit intocharlie/incompletefrom
Conversation
charliermarsh
force-pushed
the
charlie/required-platforms
branch
from
f1ae91a to
25296f7
Compare
charliermarsh
commented
Dec 19, 2024
| ] | ||
| "# | ||
| )] | ||
| pub required_platforms: Option<SupportedEnvironments>, |
Member
Author
charliermarsh
force-pushed
the
charlie/required-platforms
branch
from
25296f7 to
2f12943
Compare
charliermarsh
force-pushed
the
charlie/incomplete
branch
from
eb1d0e5 to
57e9ec4
Compare
charliermarsh
force-pushed
the
charlie/required-platforms
branch
from
2f12943 to
a2a4aa9
Compare
charliermarsh
force-pushed
the
charlie/incomplete
branch
from
57e9ec4 to
0845422
Compare
charliermarsh
force-pushed
the
charlie/required-platforms
branch
from
a2a4aa9 to
999b68c
Compare
charliermarsh
force-pushed
the
charlie/incomplete
branch
from
0845422 to
056b61c
Compare
charliermarsh
force-pushed
the
charlie/required-platforms
branch
from
999b68c to
4c2d493
Compare
konstin
reviewed
Dec 19, 2024
| /// By default, uv will require that each package includes at least one wheel for Linux, macOS, | ||
| /// and Windows. The `required-platforms` setting can be used to make those requirements more | ||
| /// or less strict. For example, an empty `required-platforms` list avoid enforcing any such | ||
| /// requirements on binary-only packages. |
Member
There was a problem hiding this comment.
We should make clearer that the specific requirement is that for each marker, there exists at least one wheel that can be installed in the marker's environment.
Member
Author
|
We merged #10046 instead for now. We may return to this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an extension of #9928 that makes the set of "required platforms" configurable, thereby making the resolver less tightly-coupled to the list of platforms.
I'm wondering if there's a way for us to reuse
environmentsfor this somehow.