Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve case-insensitive sorts in uv add #7801

Closed
KotlinIsland opened this issue Sep 30, 2024 · 3 comments · Fixed by #7864
Closed

Preserve case-insensitive sorts in uv add #7801

KotlinIsland opened this issue Sep 30, 2024 · 3 comments · Fixed by #7864
Labels
enhancement New feature or improvement to existing functionality good first issue Good for newcomers

Comments

@KotlinIsland
Copy link

i like to keep my dependencies alphabetically sorted, it would appreciate it if uv did the same
@charliermarsh
Copy link
Member

uv add does keep them sorted if they were already sorted (but it does not sort unsorted dependencies). Are you seeing otherwise?

@charliermarsh charliermarsh added the question Asking for clarification or support label Sep 30, 2024
@KotlinIsland
Copy link
Author

turns out it was because there was PyYAML in the list, i think the capitalization threw it off

@charliermarsh
Copy link
Member

I think it would be reasonable to check if the list is case-insensitive-sorted, and preserve that.

@charliermarsh charliermarsh added enhancement New feature or improvement to existing functionality and removed question Asking for clarification or support labels Oct 1, 2024
@charliermarsh charliermarsh changed the title (🎁) add should add the thing alphabetically Preserve case-insensitive sorts in uv add Oct 1, 2024
@charliermarsh charliermarsh added the good first issue Good for newcomers label Oct 1, 2024
@blueraft blueraft mentioned this issue Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement to existing functionality good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve case-insensitive sorts in uv add blueraft/uv
2 participants
@charliermarsh @KotlinIsland