You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 8011778
Browse filesBrowse the repository at this point in the historyBrowse files
Simplify editable requirement errors and hints (#21130)
## Summary
This PR does three things:
* It fixes an issue where we were printing raw URLs in errors which
could themselves contain credentials.
* It cleans up the error messages for end users, into a form which in my
opinion is cleaner and clearer.
* It makes the underlying code simpler. ~~Which I need as a preparatory
change for #20631.~~ (turns out I might not need it in the end)
## Test Plan
Snapshots adjusted, and a test-case for the issue has been added.
"Unsupported editable requirement in `{}` at line {line}: `{requirement}`",
1389
1398
self.file.user_display(),
1390
1399
)
1391
1400
}
@@ -1898,8 +1907,8 @@ mod test {
1898
1907
filters => filters
1899
1908
},{
1900
1909
insta::assert_snapshot!(errors, @"
1901
-
Unsupported editable requirement in `<REQUIREMENTS_TXT>`
1902
-
Editable must refer to a local directory, not an HTTPS URL: `https://files.pythonhosted.org/packages/f7/69/96766da2cdb5605e6a31ef2734aff0be17901cefb385b885c2ab88896d76/ruff-0.5.6.tar.gz`
1910
+
Unsupported editable requirement in `<REQUIREMENTS_TXT>` at line 1: `https://files.pythonhosted.org/packages/f7/69/96766da2cdb5605e6a31ef2734aff0be17901cefb385b885c2ab88896d76/ruff-0.5.6.tar.gz`
0 commit comments