Skip to content

Commit 2d566bc

Browse files
authored
Allow retry of custom-publish-crates separately from announce (#19470)
This adjusts `announce` to no longer wait for `custom-publish-crates` so we can retry `custom-publish-crates` without re-running `announce`. This may be temporary — once we can get crates publishing working consistently, we can roll back.
1 parent 0588b8f commit 2d566bc

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

‎.github/workflows/release.yml‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -307,12 +307,10 @@ jobs:
307307
- host
308308
- release-gate
309309
- custom-publish-pypi
310-
- custom-publish-crates
311-
# use "always() && ..." to allow us to wait for all publish jobs while
312-
# still allowing individual publish jobs to skip themselves (for prereleases).
310+
# use "always() && ..." to allow publish jobs to skip themselves (for prereleases).
313311
# "host" however must run to completion, no skipping allowed!
314-
# `custom-publish-crates` is intentionally not gated on its result: it's
315-
# not critical to the release and isn't idempotent on retry.
312+
# `custom-publish-crates` is intentionally not a dependency: it's not
313+
# critical to the release and isn't idempotent on retry.
316314
if: ${{ always() && needs.host.result == 'success' && needs.release-gate.result == 'success' && (needs.custom-publish-pypi.result == 'skipped' || needs.custom-publish-pypi.result == 'success') }}
317315
runs-on: "depot-ubuntu-latest-4"
318316
environment:
@@ -364,9 +362,8 @@ jobs:
364362
needs:
365363
- plan
366364
- announce
367-
# Use `always() && ...` so this job is not skipped when an unrelated
368-
# upstream job (e.g., `custom-publish-crates`) fails. `announce` itself
369-
# tolerates a `custom-publish-crates` failure, so we mirror that here.
365+
# Use `always() && ...` so this job gates only on whether `announce`
366+
# completed successfully.
370367
if: ${{ always() && needs.announce.result == 'success' }}
371368
uses: ./.github/workflows/publish-docs.yml
372369
with:

0 commit comments

Comments
 (0)