Skip to content

Commit 1e1d01f

Browse files
authored
Fix various comments (#20597)
## Summary This is an assortment of 10 comment fixes. Found with codex and then manually vetted.
1 parent e500216 commit 1e1d01f

9 files changed

Lines changed: 15 additions & 18 deletions

File tree

‎crates/uv-cli/src/lib.rs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6535,8 +6535,7 @@ pub enum PythonCommand {
65356535

65366536
/// Upgrade installed Python versions.
65376537
///
6538-
/// Upgrades versions to the latest supported patch release. Requires the `python-upgrade`
6539-
/// preview feature.
6538+
/// Upgrades versions to the latest supported patch release.
65406539
///
65416540
/// A target Python minor version to upgrade may be provided, e.g., `3.13`. Multiple versions
65426541
/// may be provided to perform more than one upgrade.

‎crates/uv/tests/it/branching_urls.rs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,8 @@ fn root_package_splits_but_transitive_conflict() -> Result<()> {
150150
///
151151
/// Requirements:
152152
/// ```text
153-
/// a -> anyio==4.4.0 ; python_version >= '3.12'
154-
/// a -> anyio==4.3.0 ; python_version < '3.12'
153+
/// a -> anyio==4.3.0 ; python_version >= '3.12'
154+
/// a -> anyio==4.2.0 ; python_version < '3.12'
155155
/// a -> b -> b1 ; python_version < '3.12' -> https://../iniconfig-1.1.1-py3-none-any.whl
156156
/// a -> b -> b2 ; python_version >= '3.12' -> https://../iniconfig-2.0.0-py3-none-any.whl
157157
/// ```
@@ -356,8 +356,8 @@ fn root_package_splits_transitive_too() -> Result<()> {
356356
///
357357
/// Requirements:
358358
/// ```
359-
/// a -> anyio==4.4.0 ; python_version >= '3.12'
360-
/// a -> anyio==4.3.0 ; python_version < '3.12'
359+
/// a -> anyio==4.3.0 ; python_version >= '3.12'
360+
/// a -> anyio==4.2.0 ; python_version < '3.12'
361361
/// a -> b1 ; python_version < '3.12' -> iniconfig==1.1.1
362362
/// a -> b2 ; python_version >= '3.12' -> iniconfig==2.0.0
363363
/// ```

‎crates/uv/tests/lock_scenarios/lock_conflict.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4160,7 +4160,7 @@ fn shared_optional_dependency_extra2() -> Result<()> {
41604160
"#,
41614161
)?;
41624162

4163-
// This shouldn't install two versions of `idna`, only one, `idna==3.5`.
4163+
// This shouldn't install two versions of `idna`, only one, `idna==3.6`.
41644164
uv_snapshot!(context.filters(), context.sync().arg("--extra=bar"), @"
41654165
success: true
41664166
exit_code: 0
@@ -4301,7 +4301,7 @@ fn shared_optional_dependency_group2() -> Result<()> {
43014301
"#,
43024302
)?;
43034303

4304-
// This shouldn't install two versions of `idna`, only one, `idna==3.5`.
4304+
// This shouldn't install two versions of `idna`, only one, `idna==3.6`.
43054305
uv_snapshot!(context.filters(), context.sync().arg("--group=bar"), @"
43064306
success: true
43074307
exit_code: 0
@@ -4447,7 +4447,7 @@ fn shared_optional_dependency_mixed2() -> Result<()> {
44474447
"#,
44484448
)?;
44494449

4450-
// This shouldn't install two versions of `idna`, only one, `idna==3.5`.
4450+
// This shouldn't install two versions of `idna`, only one, `idna==3.6`.
44514451
uv_snapshot!(context.filters(), context.sync().arg("--group=bar"), @"
44524452
success: true
44534453
exit_code: 0

‎crates/uv/tests/pip/pip_sync.rs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,6 @@ fn pip_sync_empty() -> Result<()> {
510510
/// virtual environment.
511511
#[test]
512512
fn link() -> Result<()> {
513-
// Sync `anyio` into the first virtual environment.
514513
let context1 = uv_test::test_context!("3.12");
515514

516515
let requirements_txt = context1.temp_dir.child("requirements.txt");

‎crates/uv/tests/pip_compile/pip_compile.rs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -538,8 +538,7 @@ fn compile_constraints_markers() -> Result<()> {
538538
}
539539

540540
/// Resolve a package from a `requirements.in` file, with a `constraints.txt` file that uses an
541-
/// extra. The constraint should be enforced, but the extra should _not_ be included in the output
542-
/// (though it currently _is_ included).
541+
/// extra. The constraint should be enforced, but the extra should _not_ be included in the output.
543542
#[test]
544543
fn compile_constraint_extra() -> Result<()> {
545544
let context = uv_test::test_context!("3.12");

‎crates/uv/tests/pip_install/pip_install.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8414,7 +8414,7 @@ fn require_hashes_missing_dependency() -> Result<()> {
84148414
"werkzeug==3.0.0 --hash=sha256:cbb2600f7eabe51dbc0502f58be0b3e1b96b893b05695ea2b35b43d4de2d9962",
84158415
)?;
84168416

8417-
// Install without error when `--require-hashes` is omitted.
8417+
// Error on the transitive dependency when `--require-hashes` is passed.
84188418
uv_snapshot!(context.pip_install()
84198419
.arg("-r")
84208420
.arg("requirements.txt")

‎crates/uv/tests/project/run.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2875,7 +2875,7 @@ fn run_no_sync() -> Result<()> {
28752875
.child("__init__.py")
28762876
.touch()?;
28772877

2878-
// Running with `--no-sync` should succeed error, even if the lockfile isn't present.
2878+
// Running with `--no-sync` should succeed, even if the lockfile isn't present.
28792879
uv_snapshot!(context.filters(), context.run().arg("--no-sync").arg("--").arg("python").arg("--version"), @"
28802880
success: true
28812881
exit_code: 0
@@ -3729,7 +3729,7 @@ fn run_no_project() -> Result<()> {
37293729
----- stderr -----
37303730
");
37313731

3732-
// `run --no-project --locked` should fail.
3732+
// `run --no-project --locked` should warn about `--locked`.
37333733
uv_snapshot!(context.filters(), context.run().arg("--no-project").arg("--locked").arg("python").arg("-c").arg("import sys; print(sys.executable)"), @"
37343734
success: true
37353735
exit_code: 0

‎crates/uv/tests/project/tree.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1850,8 +1850,8 @@ fn platform_dependencies() -> Result<()> {
18501850
Resolved 8 packages in [TIME]
18511851
");
18521852

1853-
// When `--universal` is _not_ provided, should include `colorama`, even though it's only
1854-
// included on Windows.
1853+
// When `--universal` is provided, should include `colorama`, even though it's only included on
1854+
// Windows.
18551855
uv_snapshot!(context.filters(), context.tree().arg("--universal"), @"
18561856
success: true
18571857
exit_code: 0

‎crates/uv/tests/python/python_install.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2477,7 +2477,7 @@ fn python_install_default_prerelease() {
24772477
.with_managed_python_dirs()
24782478
.with_python_download_cache();
24792479

2480-
// Install Python 3.15, which currently only exists as a pre-release (3.15.0a1).
2480+
// Install Python 3.15, which currently only exists as a pre-release.
24812481
context
24822482
.python_install()
24832483
.arg("--default")

0 commit comments

Comments
 (0)