Change workspace settings from window to resource scope#321
Merged
BurntSushi merged 1 commit intomainfrom Jan 30, 2026
Merged
Conversation
With astral-sh/ruff#22953 merged, the ty server now supports multiple workspace folders. This means we can deal with workspace settings diverging between folders. This change specifically only applies to workspace settings. The other global settings are left with a scope of `window`, since the ty server expects there to be only one value for global settings. Closes #319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With astral-sh/ruff#22953 merged, the ty server
now supports multiple workspace folders. This means we can deal with
workspace settings diverging between folders.
This change specifically only applies to workspace settings. The other
global settings are left with a scope of
window, since the ty serverexpects there to be only one value for global settings.
Closes #319