Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3266.
This updates our typing-features and typing-faq docs to account for recent changes in ty's behavior. Both the "gradual guarantee" and "fixpoint iteration" sections no longer describe our actual behavior. In both cases, I tried different ways to update the section, but ended up feeling like there was nothing that distinctive or interesting to say, so I just removed the sections entirely.
For gradual guarantee, I don't think we should have a section with that name, since in general we don't take that as a guiding principle anymore. The remaining singleton case is very niche, and already discussed in the FAQ.
For fixpoint iteration, we still do that of course, but for performance reasons we have since decided to promote literal unions much more quickly in all cyclic cases. So I wasn't able to construct any realistic case anymore where this "union of literals up to some limit" behavior is visible.