Remove dark-mode handling from PyPI-uploaded README#2422
Conversation
417e2eb to
8c585d7
Compare
|
Because our media query will switch the text to white, but the rest of the PyPI page doesn't adapt. |
|
Note I intentionally removed the complicated handling from Ruff because it wasn't necessary, so please wait to merge this. |
|
There is no media query though? It's just You're referring to the embedded query? |
|
You're saying this occurs if you visit PyPI with dark mode enabled? |
Yes.
Yeah, there's CSS within |
|
Thanks for clarifying. I missed #2422 (comment) |
|
I think I'd prefer to retain the adaptive image and add a static light image and just replace the single URL on publish? Then we don't need a srcset and don't need to replicate that in the replacement code? |
|
That's fine with me, I'll do a pass on it. |
|
Thank you! |


Summary
This matches the approach we use in Ruff.
Closes #2322.