Skip to content

Waterfall effect in ProjectFilesWalker::collect_vec #970

@MichaReiser

Description

@MichaReiser
Image

We walk the project files in parallel but all the system_path_to_file calls happen on the main thread. This is mainly because dyn Db can't be shared across threads.

There are a few solutions:

  1. Add a Files::from_walk_entry method (or similar) that returns a File from a walk entry. Extend walkentry to contain all the information needed to create a File
  2. Change ProjectFilesWalker to take a &ProjectDatabase`, which allows cloning

Metadata

Metadata

Assignees

No one assigned

    Labels

    performancePotential performance improvement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions