@carljm metaclasses decorated with @dataclass_transform(kw_only_default=True) did not forward the information to the applied classes, which is what pydantic uses
But it's ok it's now fixed

Here is a summary of current behaviour for dataclass_transform, attrs and pydantic

import attrs
import pydantic
from typing import dataclass_transform, reveal_type
from dataclasses import dataclass


@dataclass(kw_only=True)
class DataclassUser:
    name: str
    age: int


reveal_type(DataclassUser.__init__)
# # `(self: DataclassUser, *, name: str, age: int) -> None` 🟢 


@dataclass_transform(kw_only_default=True)
def model(cls):
    return cls


@model
class CustomUser:
    name: str
    age: int


reveal_type(CustomUser.__init__)
# `(self: CustomUser, *, name: str, age: int) -> None` 🟢


@dataclass_transform(kw_only_default=True)
class ModelMeta(type):
    pass


class CustomModel(metaclass=ModelMeta):
    def __init__(self, **data):
        for k, v in data.items():
            setattr(self, k, v)


class CustomMetaclassUser(CustomModel):
    name: str
    age: int


reveal_type(CustomMetaclassUser.__init__)
# `(self: CustomMetaclassUser, name: str, age: int) -> None` 🟠 (`kw_only_default` not recognised)

@attrs.define(kw_only=True)
class AttrsUser:
    name: str
    age: int


reveal_type(AttrsUser.__init__)
# `(self: AttrsUser, name: str, age: int) -> None` 🟠
# (`kw_only_default` not recognised but expected because stub file doesn't add `kw_only_default` in `@dataclass_transform`)


class PydanticUser(pydantic.BaseModel):
    name: str
    age: int


reveal_type(PydanticUser.__init__)
# `(self: PydanticUser, __pydantic_extra__: @Todo(unknown type subscript) | None = Any, __pydantic_fields_set__: set[str] = Any, __pydantic_private__: @Todo(unknown type subscript) | None = Any, name: str, age: int) -> None` 🔴
# `kw_only_default` not recognised because Pydantic uses metaclass
# extra fields in signature that will be removed when `field_specifiers` are implemented)

support field_specifiers in dataclass_transform #1068

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions