Skip to content

Commit f0ea525

Browse files
authored
Remove unused mold setup from daily tests (#4797)
The daily fuzzing and property-test workflows install `mold`, but their Rust builds already use bundled `lld` on `x86_64-unknown-linux-gnu`. Remove the unused installation steps. [Eight pairs of builds of the `ty_python_semantic` release test binaries](https://github.com/astral-sh/ruff/actions/runs/39841713358) on 4-vCPU CI runners averaged 367.8 s with `mold` installation and 361.9 s without. Each pair built both variants on the same runner from empty target directories, with build order alternated. Times include installation when applicable and exclude dependency downloads. The mean change was −5.8 s (two-sided 90% paired t confidence interval: −15.2 to +3.5 s); the interval includes zero. Co-authored-by: zaniebot <[email protected]>
1 parent b136893 commit f0ea525

2 files changed

Lines changed: 0 additions & 4 deletions

File tree

‎.github/workflows/daily_fuzz.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@ jobs:
7777
- name: Install Rust toolchain
7878
working-directory: ruff
7979
run: rustup show
80-
- name: Install mold
81-
uses: rui314/setup-mold@9c9c13bf4c3f1adef0cc596abc155580bcb04444 # v1
8280
- uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2.9.2
8381
with:
8482
workspaces: ruff

‎.github/workflows/daily_property_tests.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ jobs:
3636
repository: astral-sh/ruff
3737
- name: "Install Rust toolchain"
3838
run: rustup show
39-
- name: "Install mold"
40-
uses: rui314/setup-mold@9c9c13bf4c3f1adef0cc596abc155580bcb04444 # v1
4139
- uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2.9.2
4240
- name: Build ty
4341
# A release build takes longer (2 min vs 1 min), but the property tests run much faster in release

0 commit comments

Comments
 (0)