Skip to content

Comments

Change default to "latest"#37

Merged
charliermarsh merged 2 commits intomainfrom
charlie/latest
Sep 5, 2024
Merged

Change default to "latest"#37
charliermarsh merged 2 commits intomainfrom
charlie/latest

Conversation

@charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Sep 4, 2024

Summary

Also did some light editing of the README.

@charliermarsh charliermarsh requested a review from zanieb September 4, 2024 21:24
@charliermarsh
Copy link
Member Author

charliermarsh commented Sep 4, 2024

@eifinger -- Anything else that I'm missing here?

@charliermarsh charliermarsh force-pushed the charlie/latest branch 3 times, most recently from c451d90 to 4d52f78 Compare September 4, 2024 23:17
zanieb
zanieb reviewed Sep 4, 2024
View reviewed changes
@charliermarsh charliermarsh mentioned this pull request Sep 5, 2024
Merged
@henryiii
Copy link

henryiii commented Sep 5, 2024

Does this do less caching? From what I understood, using a fixed version would cache uv. Before it was fixed based on the version of this action?

eifinger
eifinger approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@eifinger eifinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. It was missing to remove the "automatic" default version upgrade but I think that is better placed in a separate PR: #39

We should also clearly communicate this breaking change in the release note for existing users of this action. (added the breaking-change label to this PR)

@eifinger
Copy link
Collaborator

eifinger commented Sep 5, 2024

Does this do less caching? From what I understood, using a fixed version would cache uv. Before it was fixed based on the version of this action?

Yes, but only for self-hosted runners. See the added note in the readme:
image
https://github.com/astral-sh/setup-uv/pull/37/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R38-R40

On GitHub hosted runners we always download uv since there is no persistent TOOL_CACHE.

Base automatically changed from charlie/prettier to main September 5, 2024 12:06
@charliermarsh
Copy link
Member Author

charliermarsh commented Sep 5, 2024

I think we can also do a bit more work to improve the caching if it's impactful for self-hosted users (it's still <1s on GitHub Runners as-is): #45

@zanieb
Copy link
Member

zanieb commented Sep 5, 2024

When we release this, should it be as v2?

@charliermarsh
Copy link
Member Author

charliermarsh commented Sep 5, 2024

Works for me!

@charliermarsh @eifinger
Update README.md
3c8852d 
Co-authored-by: Kevin Stillhammer <[email protected]>
@charliermarsh charliermarsh merged commit bfebbf8 into main Sep 5, 2024
@charliermarsh charliermarsh deleted the charlie/latest branch September 5, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eifinger eifinger eifinger approved these changes

@zanieb zanieb zanieb approved these changes

Assignees

No one assigned

Labels

breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charliermarsh @henryiii @eifinger @zanieb