Conversation
amyreese
force-pushed
the
amy/markdown-support
branch
from
bece24a to
3bd7776
Compare
ntBre
reviewed
Feb 5, 2026
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
This looks reasonable to me, but it's probably best to get a look from Dhruv too, and I assume the Ruff PR needs to land first as well?
Member
Author
|
I think this is ok to land, because it won't go out until the next time we release the extension. We should wait for the Ruff PR to land and the next patch release at the very least before publishing an update to the vscode plugin. |
dhruvmanila
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes necessary to support markdown formatting in ruff's LSP in vscode:
astral-sh/ruff#23063