Check Jupyter notebooks by default, in sync with 0.6.0#96
Merged
AlexWaygood merged 3 commits intoastral-sh:mainfrom Aug 15, 2024
Merged
Check Jupyter notebooks by default, in sync with 0.6.0#96AlexWaygood merged 3 commits intoastral-sh:mainfrom
AlexWaygood merged 3 commits intoastral-sh:mainfrom
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
MichaReiser
reviewed
Aug 15, 2024
Co-authored-by: Micha Reiser <[email protected]>
Member
|
Sorry for the oversight on our end and thanks for PRing a fix. This looks good but I'm also a complete pre-commit noob (and non-user). @AlexWaygood would you mind taking a look. |
AlexWaygood
reviewed
Aug 15, 2024
AlexWaygood
reviewed
Aug 15, 2024
| # Run the linter. | ||
| - id: ruff | ||
| types_or: [ python, pyi, jupyter ] | ||
| types_or: [ python, pyi ] |
Member
There was a problem hiding this comment.
types_or overwrites the default config in .pre-commit-hooks.yaml rather than extending it, correct? I think that's what we want this example to show, I'm just double-checking.
Contributor
Author
There was a problem hiding this comment.
Yes, that's how everything in pre-commit works. Users can override anything.
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close #95
Test Plan