Merged
Conversation
charliermarsh
approved these changes
Feb 1, 2024
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| TRY200 | 636 | 0 | 636 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check encountered linter errors. (no lint changes; 2 project errors)
fronzbot/blinkpy (error)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in your configuration:
- 'ignore' -> 'lint.ignore'
- 'select' -> 'lint.select'
- 'mccabe' -> 'lint.mccabe'
- 'per-file-ignores' -> 'lint.per-file-ignores'
ruff failed
Cause: Selection of deprecated rule `TRY200` is not allowed when preview is enabled.
sphinx-doc/sphinx (error)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
warning: The `show-source` option has been deprecated in favor of `output-format`'s "full" and "concise" variants. Please update your configuration to use `output-format = <full|concise>` instead.
ruff failed
Cause: Selection of deprecated rule `ANN102` is not allowed when preview is enabled.
8d4d156 to
5076945
Compare
Merged
zanieb
added a commit
that referenced
this pull request
Feb 1, 2024
zanieb
added a commit
that referenced
this pull request
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9754 and #9689. Alternative to #9714.
Marks
TRY200as removed and redirects toB904instead of marking as deprecated and suggestingB904instead.