Skip to content

Comments

Add tests for redirected rules#9754

Merged
zanieb merged 3 commits intorelease/0.2.0from
zb/deprecated-renamed
Feb 1, 2024
Merged

Add tests for redirected rules#9754
zanieb merged 3 commits intorelease/0.2.0from
zb/deprecated-renamed

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Feb 1, 2024 •
edited
Loading

Extends #9752 adding internal test rules for redirection

Fixes a bug where we did not see warnings for exact codes that are redirected (just prefixes)

@zanieb zanieb force-pushed the zb/deprecated-renamed branch from c53a810 to 65b14fb Compare February 1, 2024 15:34
@zanieb zanieb changed the title zb/deprecated renamed Add tests for redirected rules Feb 1, 2024
@zanieb zanieb force-pushed the zb/deprecated-renamed branch from d25c4fb to 16684b1 Compare February 1, 2024 15:41
@zanieb zanieb added the internal An internal refactor or improvement label Feb 1, 2024
@zanieb zanieb force-pushed the zb/deprecated-renamed branch from 16684b1 to 8d4d156 Compare February 1, 2024 15:45
This was referenced Feb 1, 2024
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error) 

warning: The `show-source` option has been deprecated in favor of `output-format`'s "full" and "concise" variants. Please update your configuration to use `output-format = <full|concise>` instead.
warning: `RUF011` has been remapped to `B035`.
warning: `TCH006` has been remapped to `TCH010`.
ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB131
	- FURB113
	- FURB132

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 2 project errors)

fronzbot/blinkpy (error) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in your configuration:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'mccabe' -> 'lint.mccabe'
  - 'per-file-ignores' -> 'lint.per-file-ignores'


ruff failed
  Cause: Selection of deprecated rule `TRY200` is not allowed when preview is enabled.

sphinx-doc/sphinx (error) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

warning: The `show-source` option has been deprecated in favor of `output-format`'s "full" and "concise" variants. Please update your configuration to use `output-format = <full|concise>` instead.
ruff failed
  Cause: Selection of deprecated rule `ANN102` is not allowed when preview is enabled.

@charliermarsh charliermarsh self-requested a review February 1, 2024 16:09
Base automatically changed from zb/remove-deprecated-tests to release/0.2.0 February 1, 2024 16:28
@zanieb zanieb force-pushed the zb/deprecated-renamed branch from 8d4d156 to 5076945 Compare February 1, 2024 16:30
@zanieb zanieb merged commit 003a360 into release/0.2.0 Feb 1, 2024
@zanieb zanieb deleted the zb/deprecated-renamed branch February 1, 2024 16:46
zanieb added a commit that referenced this pull request Feb 1, 2024
@zanieb
Redirect TRY200 to B904 (#9755)
f6812ee 
Follow-up to #9754 and #9689. Alternative to #9714.

Marks `TRY200` as removed and redirects to `B904` instead of marking as
deprecated and suggesting `B904` instead.
zanieb added a commit that referenced this pull request Feb 1, 2024
@zanieb
Redirect PHG001 to S307 and PGH002 to G010 (#9756)
8c18fc7 
Follow-up to #9754 and #9689. Alternative to #9714.
Replaces #7506 and #7507
Same ideas as #9755
Part of #8931
zanieb added a commit that referenced this pull request Feb 1, 2024
@zanieb
Add tests for redirected rules (#9754)
0d752e5 
Extends #9752 adding internal test
rules for redirection

Fixes a bug where we did not see warnings for exact codes that are
redirected (just prefixes)
zanieb added a commit that referenced this pull request Feb 1, 2024
@zanieb
Redirect TRY200 to B904 (#9755)
a578414 
Follow-up to #9754 and #9689. Alternative to #9714.

Marks `TRY200` as removed and redirects to `B904` instead of marking as
deprecated and suggesting `B904` instead.
zanieb added a commit that referenced this pull request Feb 1, 2024
@zanieb
Redirect PHG001 to S307 and PGH002 to G010 (#9756)
994514d 
Follow-up to #9754 and #9689. Alternative to #9714.
Replaces #7506 and #7507
Same ideas as #9755
Part of #8931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

No one assigned

Labels

internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanieb @charliermarsh