Skip to content

Comments

Use fake rules for testing deprecation and removal infrastructure#9752

Merged
zanieb merged 3 commits intorelease/0.2.0from
zb/remove-deprecated-tests
Feb 1, 2024
Merged

Use fake rules for testing deprecation and removal infrastructure#9752
zanieb merged 3 commits intorelease/0.2.0from
zb/remove-deprecated-tests

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Feb 1, 2024 •
edited
Loading

Updates #9689 and #9691 to use rule testing infrastructure from #9747

@zanieb zanieb requested a review from charliermarsh February 1, 2024 15:14
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error) 

warning: The `show-source` option has been deprecated in favor of `output-format`'s "full" and "concise" variants. Please update your configuration to use `output-format = <full|concise>` instead.
ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB131
	- FURB113
	- FURB132

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 2 project errors)

fronzbot/blinkpy (error) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in your configuration:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'mccabe' -> 'lint.mccabe'
  - 'per-file-ignores' -> 'lint.per-file-ignores'


ruff failed
  Cause: Selection of deprecated rule `TRY200` is not allowed when preview is enabled.

sphinx-doc/sphinx (error) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

warning: The `show-source` option has been deprecated in favor of `output-format`'s "full" and "concise" variants. Please update your configuration to use `output-format = <full|concise>` instead.
ruff failed
  Cause: Selection of deprecated rule `ANN102` is not allowed when preview is enabled.

@zanieb zanieb mentioned this pull request Feb 1, 2024
Merged
@zanieb zanieb added the internal An internal refactor or improvement label Feb 1, 2024
@zanieb zanieb merged commit dcc69f2 into release/0.2.0 Feb 1, 2024
@zanieb zanieb deleted the zb/remove-deprecated-tests branch February 1, 2024 16:28
zanieb added a commit that referenced this pull request Feb 1, 2024
@zanieb
Add tests for redirected rules (#9754)
003a360 
Extends #9752 adding internal test
rules for redirection

Fixes a bug where we did not see warnings for exact codes that are
redirected (just prefixes)
zanieb added a commit that referenced this pull request Feb 1, 2024
@zanieb
Use fake rules for testing deprecation and removal infrastructure (#9752
46c0937 
)

Updates #9689 and #9691 to use rule testing infrastructure from #9747
zanieb added a commit that referenced this pull request Feb 1, 2024
@zanieb
Add tests for redirected rules (#9754)
0d752e5 
Extends #9752 adding internal test
rules for redirection

Fixes a bug where we did not see warnings for exact codes that are
redirected (just prefixes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

No one assigned

Labels

internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanieb @charliermarsh