[flake8-pyi] Mark unaliased-collections-abc-set-import fix as safe#9679
Merged
charliermarsh merged 1 commit intorelease/0.2.0from Jan 29, 2024
Merged
[flake8-pyi] Mark unaliased-collections-abc-set-import fix as safe#9679charliermarsh merged 1 commit intorelease/0.2.0from
flake8-pyi] Mark unaliased-collections-abc-set-import fix as safe#9679charliermarsh merged 1 commit intorelease/0.2.0from
Conversation
charliermarsh
added
fixes
Member
Author
|
For 0.2. |
zanieb
approved these changes
Jan 29, 2024
Member
zanieb
left a comment
zanieb
left a comment
There was a problem hiding this comment.
I guess it's unsafe if the name is being exported?
Member
Author
|
That's... true |
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PYI001 | 1 | 1 | 0 | 0 | 0 |
charliermarsh
force-pushed
the
charlie/PYI025
branch
from
ef151af to
42929e0
Compare
charliermarsh
force-pushed
the
charlie/PYI025
branch
from
42929e0 to
ee90cf8
Compare
Member
Author
|
I marked it as safe, unless it's at the top level. |
Merged
zanieb
pushed a commit
that referenced
this pull request
Jan 29, 2024
#9679) ## Summary Prompted by #8482 (comment). The rename is only unsafe when the symbol is exported, so we can narrow the conditions.
zanieb
pushed a commit
that referenced
this pull request
Jan 30, 2024
#9679) ## Summary Prompted by #8482 (comment). The rename is only unsafe when the symbol is exported, so we can narrow the conditions.
zanieb
pushed a commit
that referenced
this pull request
Feb 1, 2024
#9679) ## Summary Prompted by #8482 (comment). The rename is only unsafe when the symbol is exported, so we can narrow the conditions.
zanieb
pushed a commit
that referenced
this pull request
Feb 1, 2024
#9679) ## Summary Prompted by #8482 (comment). The rename is only unsafe when the symbol is exported, so we can narrow the conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prompted by #8482 (comment). The rename is only unsafe when the symbol is exported, so we can narrow the conditions.