Add as_slice method for all string nodes#9111
Merged
dhruvmanila merged 2 commits intomainfrom Dec 13, 2023
Merged
Conversation
This method returns all the parts of an implicitly concatenated string as a slice. If it's not implicitly concatenated, it'll return a slice with a single element.
Member
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
MichaReiser
approved these changes
Dec 13, 2023
Contributor
|
mdbernard
pushed a commit
to mdbernard/ruff
that referenced
this pull request
Dec 18, 2023
This PR adds a `as_slice` method to all the string nodes which returns all the parts of the nodes as a slice. This will be useful in the next PR to split the string formatting to use this method to extract the _single node_ or _implicitly concanated nodes_.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
as_slicemethod to all the string nodes which returns all the parts of the nodes as a slice. This will be useful in the next PR to split the string formatting to use this method to extract the single node or implicitly concanated nodes.