F841: support fixing unused assignments in tuples by renaming variables#9107
Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom Dec 12, 2023
Merged
F841: support fixing unused assignments in tuples by renaming variables#9107charliermarsh merged 1 commit intoastral-sh:mainfrom
charliermarsh merged 1 commit intoastral-sh:mainfrom
Conversation
762a5aa to
173d443
Compare
173d443 to
0fc951f
Compare
Contributor
|
charliermarsh
approved these changes
Dec 12, 2023
Member
charliermarsh
left a comment
There was a problem hiding this comment.
Nice, this makes sense to me. Appreciate the clear rationale too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A fairly common pattern which triggers F841 is unused variables from tuple assignments, e.g.:
This error is currently not auto-fixable.
This PR adds support for fixing the error automatically by renaming the unused variable to have a leading underscore (i.e.
_created) iff thedummy-variable-rgxsetting would match it.I considered using
renamers::Renamerhere, but because by the nature of the error there should be no references to it, that seemed like overkill. Also note that the fix might break by shadowing the new name if it is already used elsewhere in the scope. I left it as is because