Ruff ecosystem: pass no-preview cli arg by default#8775
Merged
zanieb merged 7 commits intoastral-sh:mainfrom Nov 20, 2023
Merged
Ruff ecosystem: pass no-preview cli arg by default#8775zanieb merged 7 commits intoastral-sh:mainfrom
zanieb merged 7 commits intoastral-sh:mainfrom
Conversation
Member
|
Thanks! You can add this to the formatter too. We don't use comparisons with Black in CI anyway. |
zanieb
reviewed
Nov 20, 2023
T-256
changed the title
We should test the ecosystem on ecosystem module changes for example
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #8489 (comment)
That issues still exist on formatter, but since
blackdoesn't supportno-previewcli arg, I didn't include it in this PR.