Retain extra ellipses in protocols and abstract methods#8769
Merged
charliermarsh merged 1 commit intomainfrom Nov 19, 2023
Merged
Retain extra ellipses in protocols and abstract methods#8769charliermarsh merged 1 commit intomainfrom
charliermarsh merged 1 commit intomainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PIE790 | 24 | 0 | 24 | 0 | 0 |
Member
Author
|
The ecosystem changes are correct (they were false positives given this new information). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It turns out that some type checkers rely on the presence of ellipses in
Protocolinterfaces and abstract methods, in order to differentiate between default implementations and stubs. This PR modifies the preview behavior ofPIE790to avoid flagging "unnecessary" ellipses in such cases.Closes #8756.
Test Plan
cargo test