Skip to content

Comments

Run both stable and preview ecosystem checks#8422

Merged
zanieb merged 2 commits intomainfrom
zanie/eco-preview
Nov 2, 2023
Merged

Run both stable and preview ecosystem checks#8422
zanieb merged 2 commits intomainfrom
zanie/eco-preview

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Nov 1, 2023

Closes #8076
Follow-up to #8358

Doubles the amount of ecosystem checks we do, adding separate groups for the stable sections.

We're likely to run into GitHub comment length restrictions if there are significant deviations. However, it should not be common for changes in stable and preview to occur at the same time, nor should it be common for linter and formatter changes to occur at the same time.

Comment on lines -51 to 52
run: |
echo '## PR Check Results' >> comment.txt

echo "### Ecosystem" >> comment.txt
echo '## `ruff-ecosystem` results' >> comment.txt
cat pr/ecosystem/ecosystem-result >> comment.txt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will not take effect until after merge. I can manually dispatch to test if desired.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing a manual dispatch might be good. Just be to sure

@zanieb zanieb added the internal An internal refactor or improvement label Nov 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

ruff-ecosystem results

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@zanieb zanieb force-pushed the zanie/eco-preview branch from 22238aa to 6dfea78 Compare November 1, 2023 22:29
@MichaReiser
Copy link
Member

PR Check Results

Ecosystem

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Should we rename Ecosystem to Linter? Or use different headings:

Linter

Stable

Preview

Formatter

@zanieb
Copy link
Member Author

zanieb commented Nov 2, 2023

@MichaReiser you commented on the output from the old pr-comment. I can run manual dispatch and it should reset to the correct output.

@zanieb
Copy link
Member Author

zanieb commented Nov 2, 2023

Sure is slow!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@zanieb
Copy link
Member Author

zanieb commented Nov 2, 2023

@zanieb zanieb merged commit df4dc04 into main Nov 2, 2023
@zanieb zanieb deleted the zanie/eco-preview branch November 2, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run ecosystem checks with and without preview enabled

2 participants