Propagate exit code through Python __main__ wrapper#776
Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom Nov 16, 2022
Merged
Propagate exit code through Python __main__ wrapper#776charliermarsh merged 1 commit intoastral-sh:mainfrom
charliermarsh merged 1 commit intoastral-sh:mainfrom
Conversation
Jackenmen
reviewed
Nov 16, 2022
ruff/__main__.py
Outdated
| if __name__ == "__main__": | ||
| ruff = os.path.join(sysconfig.get_path("scripts"), "ruff") | ||
| os.spawnv(os.P_WAIT, ruff, [ruff, *sys.argv[1:]]) | ||
| exit(os.spawnv(os.P_WAIT, ruff, [ruff, *sys.argv[1:]])) |
Contributor
There was a problem hiding this comment.
exit() is not a built-in function and is only defined if the site module is imported during Python's initialization (which, for example, can be disabled with -S option passed to the interpreter). You should use sys.exit() instead:
Suggested change
| exit(os.spawnv(os.P_WAIT, ruff, [ruff, *sys.argv[1:]])) | |
| sys.exit(os.spawnv(os.P_WAIT, ruff, [ruff, *sys.argv[1:]])) |
Contributor
Author
There was a problem hiding this comment.
Fixed, thanks. (Ruff should have a rule for this!)
Fixes astral-sh#775. Signed-off-by: Anders Kaseorg <[email protected]>
andersk
force-pushed
the
wrapper-exit
branch
from
a2f70f5 to
bf0e5c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #775.