Skip to content

Comments

Break with on end-of-line trailing comments#7685

Merged
charliermarsh merged 1 commit intomainfrom
charlie/with-comment
Sep 28, 2023
Merged

Break with on end-of-line trailing comments#7685
charliermarsh merged 1 commit intomainfrom
charlie/with-comment

Conversation

@charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Sep 28, 2023

Summary

Ensures that:

with (
    a  # comment
):
    pass

Retains its parentheses.

Closes #6750.

Test Plan

cargo test

No change in similarity.

@charliermarsh charliermarsh added the formatter Related to the formatter label Sep 28, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) September 28, 2023 00:14
@charliermarsh charliermarsh enabled auto-merge (squash) September 28, 2023 00:15
@charliermarsh charliermarsh merged commit a6d79c0 into main Sep 28, 2023
@charliermarsh charliermarsh deleted the charlie/with-comment branch September 28, 2023 00:16
@MichaReiser
Copy link
Member

MichaReiser commented Sep 28, 2023

Does this change the similarity index in anyway? I checked. The similarity index remains unchanged.

@charliermarsh
Copy link
Member Author

I checked too, it’s in the PR summary :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

formatter Related to the formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Formatter: inconsistency for parenthesized with with trailing comment

2 participants