Preserve newlines after nested compound statements#7608
Merged
charliermarsh merged 2 commits intomainfrom Sep 25, 2023
Merged
Conversation
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
8388c0a to
2395178
Compare
MichaReiser
approved these changes
Sep 25, 2023
konstin
approved these changes
Sep 25, 2023
Co-authored-by: konsti <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Given:
We want to preserve the newline after the
# c(before theelse). However, thelast_nodeends at thepass, and the comments are trailing comments on thepass, not trailing comments on thelast_node(theif). As such, when counting the trailing newlines on the outerif, we abort as soon as we see the comment (# a).This PR changes the logic to skip all comments (even those with newlines between them). This is safe as we know that there are no "leading" comments on the
else, so there's no risk of skipping those accidentally.Closes #7602.
Test Plan
No change in compatibility.
Before:
After: