Skip to content

Comments

Rename ConfigurationOptions derive macro to OptionsMetadata#7599

Merged
MichaReiser merged 1 commit intomainfrom
rename-configuration-options
Sep 27, 2023
Merged

Rename ConfigurationOptions derive macro to OptionsMetadata#7599
MichaReiser merged 1 commit intomainfrom
rename-configuration-options

Conversation

@MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Sep 22, 2023

Summary

It's common practice to name derive macros the same as the trait that they implement (Debug, Display, Eq, Serialize, ...).

This PR renames the ConfigurationOptions derive macro to OptionsMetadata to match the trait name.

Test Plan

cargo build

This was referenced Sep 22, 2023
Merged
Merged
Merged
@MichaReiser
Copy link
Member Author

MichaReiser commented Sep 22, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@MichaReiser MichaReiser mentioned this pull request Sep 22, 2023
Merged
@MichaReiser MichaReiser added the internal An internal refactor or improvement label Sep 22, 2023
@MichaReiser MichaReiser force-pushed the rename-configuration-options branch from 45f759f to a304bab Compare September 22, 2023 15:49
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 22, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #7599 will create unknown performance changes

Comparing rename-configuration-options (2aa74bd) with main (0c65d0c)

Summary

🆕 25 new benchmarks

Benchmarks breakdown

Benchmark main rename-configuration-options Change
🆕 formatter[unicode/pypinyin.py] N/A 3.4 ms N/A
🆕 linter/default-rules[numpy/ctypeslib.py] N/A 18.6 ms N/A
🆕 formatter[numpy/globals.py] N/A 1.1 ms N/A
🆕 linter/default-rules[pydantic/types.py] N/A 37.4 ms N/A
🆕 linter/all-rules[numpy/globals.py] N/A 4.1 ms N/A
🆕 linter/default-rules[large/dataset.py] N/A 90.6 ms N/A
🆕 lexer[pydantic/types.py] N/A 4 ms N/A
🆕 linter/default-rules[unicode/pypinyin.py] N/A 6.2 ms N/A
🆕 linter/all-rules[large/dataset.py] N/A 163 ms N/A
🆕 linter/all-rules[pydantic/types.py] N/A 72.2 ms N/A
🆕 linter/default-rules[numpy/globals.py] N/A 2.2 ms N/A
🆕 formatter[numpy/ctypeslib.py] N/A 10 ms N/A
🆕 formatter[large/dataset.py] N/A 52.4 ms N/A
🆕 parser[numpy/ctypeslib.py] N/A 12.3 ms N/A
🆕 lexer[large/dataset.py] N/A 9 ms N/A
🆕 parser[unicode/pypinyin.py] N/A 4.2 ms N/A
🆕 parser[large/dataset.py] N/A 67.3 ms N/A
🆕 lexer[numpy/globals.py] N/A 228.8 µs N/A
🆕 parser[numpy/globals.py] N/A 1.4 ms N/A
🆕 lexer[numpy/ctypeslib.py] N/A 1.9 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@MichaReiser MichaReiser force-pushed the rename-configuration-options branch from a304bab to cc8cb51 Compare September 22, 2023 16:20
@MichaReiser MichaReiser force-pushed the rename-configuration-options branch from cc8cb51 to 68b8ed4 Compare September 22, 2023 16:36
@dhruvmanila dhruvmanila mentioned this pull request Sep 24, 2023
Merged
@MichaReiser MichaReiser force-pushed the rename-configuration-options branch from 68b8ed4 to 22fd4ee Compare September 25, 2023 08:41
@MichaReiser MichaReiser force-pushed the lint-options branch 2 times, most recently from 5d2086a to 8827264 Compare September 27, 2023 06:28
@MichaReiser MichaReiser force-pushed the rename-configuration-options branch from 22fd4ee to 2defa2e Compare September 27, 2023 06:29
Base automatically changed from lint-options to main September 27, 2023 06:46
@MichaReiser
Copy link
Member Author

MichaReiser commented Sep 27, 2023 •
edited
Loading

Merge Activity

  • Sep 27, 2:48 AM: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Sep 27, 3:04 AM: @MichaReiser merged this pull request with Graphite.

@MichaReiser MichaReiser force-pushed the rename-configuration-options branch from 2defa2e to 2aa74bd Compare September 27, 2023 06:48
@MichaReiser MichaReiser merged commit e863fa5 into main Sep 27, 2023
@MichaReiser MichaReiser deleted the rename-configuration-options branch September 27, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

No one assigned

Labels

internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaReiser @charliermarsh