Deprecate PGH002 in favor of G010#7507
Closed
charliermarsh wants to merge 1 commit intocharlie/PGH001from
Closed
Conversation
dhruvmanila
approved these changes
Sep 19, 2023
Member
|
Is this a breaking change? What should we note down in the changelog? |
konstin
approved these changes
Sep 19, 2023
Member
|
Related discussion re breaking change at #7506 |
Member
|
Closing in favor of #8931 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These rules are identical.
flake8-logging-formatis the more popular and more well-defined category, so we removePGH002and add a redirect toG010. (By adding the redirect, we ensure that users see a warning but not an error when they referencePGH002in their configuration or in a# noqa, and that those codes seamlessly redirect toG010.)Part of #7502.