Remove triple-quoted string ranges computation#7476
Merged
dhruvmanila merged 1 commit intomainfrom Sep 18, 2023
Merged
Conversation
Member
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
dhruvmanila
force-pushed
the
dhruv/indexer-cleanup
branch
from
23e3d81 to
72e092f
Compare
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
Member
Author
|
(Merging this as it's just a mechanical refactor) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up PR for #7435 to remove the now unused triple-quoted string
ranges from the indexer.
Micha raised a point about it but I don't think that's going to be a problem as
it was never used in
add-noqain the first place. In the context of f-stringwe would actually be using the f-string ranges instead as even single-quoted
f-string can be multi-line.